ECMsgTypes: fix constructor temp_added/temp_removed ordering to match users

Signed-off-by: Samuel Just <sam.just@inktank.com>
PGBackend/ECBackend: handle temp objects correctly

Signed-off-by: Samuel Just <sam.just@inktank.com>
ECBackend,ReplicatedPG: delete temp if we didn't get the transaction

We always send the transaction for operations on temp objects,
but if we didn't get the final transacition on the actual object,
we might end up failing to remove the temp object.  Thus, if
we get a sub op and don't have the transaction, just remove the
named temp objects.

Fixes: #7447
Signed-off-by: Samuel Just <sam.just@inktank.com>
Merge remote-tracking branch 'upstream/wip-7447' into firefly

Reviewed-by: Greg Farnum <greg@inktank.com>
ReplicatedPG::fill_in_copy_get: fix early return bug

This is not a leak: we are in an else block where cb must
be NULL.  The fix as introduced did not include braces on
the if causing the method to return unconditionally.

Fixes: #7604
Introduced in: 500206d809f0cd85cd99e4f0ec164bbf74f92c28
Reviewed-by: David Zafman <david.zafman@inktank.com>
Signed-off-by: Samuel Just <sam.just@inktank.com>