Port update now correctly allocates multiple IPs

RM10187

If multiple new fixed_ips were passed to update_port, the functionality
incorrectly passed previously allocated IPs back into subsequent calls
to allocate.

Assuming N IP addresses were requested, and the first of those was
successfully allocated. The behavior of the second IP address allocation
would result in one of two behaviors:

1) If the IP existed and was deallocated, it would allocate it and work
   as expected
2) If the IP did NOT exist, the strategy satisfaction check between
   reallocating an old and allocating a new would return True, as
   the first IP allocated was passed in as part of the "addresses" list.

This patch ensures that a fresh "addresses" list is passed to each
allocation call, and the result of which is pushed onto a cumulative
list.
Well I can justify it or I can say "yeah, I know. It's one of those things that got done late in the process and we know it needs doing :-/"



> On Oct 28, 2014, at 5:55 PM, Josh Conant <notifications@github.com> wrote:
> 
> In quark/plugin_modules/ports.py:
> 
> >                      port_db["id"], reuse_after=None, ip_addresses=[ip],
> >                      subnets=[ip_addresses[ip]])
> > +                addresses.extend(allocated)
> This kind of confusion is why I prefer operating on the return value instead of a shared scope variable (the latter being more java-like). Not sure why we did it this way for allocate_ip_address. Good fix, regardless.
> 
> —
> Reply to this email directly or view it on GitHub.