[446060] Replace "Lozenge" by "Diamond"

Bug: 446060
Change-Id: I83bc67d59d01f2865ba08a67b2e0cf6f50d925e9
Signed-off-by: Belqassim Djafer <belqassim.djafer@obeo.fr>
[test] fix LockedTabBarTest, NotInvisibleTabBarTest and TabBarTest

As the "Design" viewpoint is now selected on "tc2216.aird", remove the
manual viewpoint selection in order to speed up the execution of these
tests.

Change-Id: I601ec03964940b0ff7c42c67436afa580db28ba2
Signed-off-by: Mickael LANOE <mickael.lanoe@obeo.fr>
[428752] Switch auto-completion to PROPOSAL_REPLACE mode (1/2 src)

Fix auto-completion when case is not respected.
The content proposal adapter is switched to
ContentProposalAdapter.PROPOSAL_REPLACE This allows to replace the full
content of the expression allowing to change bad case, written by user,
by the good one proposed in autocompletion.

Bug 428752
Change-Id: I2047f25b31250a93ac735933942d1f1f331524cb
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
[428752] Switch auto-completion to PROPOSAL_REPLACE mode (2/2 src-gen)

this commit is designed to backporting
this commit contains only generated source code

Fix auto-completion when case is not respected.
The content proposal adapter is switched to
ContentProposalAdapter.PROPOSAL_REPLACE This allows to replace the full
content of the expression allowing to change bad case, written by user,
by the good one proposed in autocompletion.

Bug 428752
Change-Id: I9d69a29c7772034a0cc3bcb95dc50fc14feed7cc
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
[453036] Do not fail if the reconnected edge has not the expected src or
tgt.

* Those commands retrieve the reconnected edge from the source or target
node. In the case where the new edge source or the new edge target is
different, we cannot retrieve the reconnected edge. Those commands do
not need to be executed since the edge is different.
* Add a new test case to check this issue

Bug: 453036
Change-Id: Ic1a6a451256556779786d708cfbaba0f88318689
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
[453753] Have ComposedAdapterFactory disposed to avoid memory leak

Have ComposedAdapterFactory disposed to avoid memory leak.

Bug: 453753
Change-Id: I07e735b8c4c725146b54565fc470f5aaddb97107
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
[428752] move autocompletion binding from src-gen to src

note: API modified
The code about binding between property section and auto-completion is
moved from src-gen to
TextContentProposalProvider.bindCompletionProcessor method.
The generated code is replaced by the call to this method.

Bug 428752
Change-Id: I09cac08d306e1db2a53ef45478469a16d152f6ab
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
[452962] Improve Session resources cleanup on close
    
- clear DAnlysisSessionEObject.activatedViewpoints to avoid potential
Viewpoint reloading on proxy resolution.
- Give Session in constructor of RepresentationNameListener to avoid get
Session from SessionManager.
- Remove useless try/catch NPE in RepresentationsChangeAdapter as it was
for a CDO bug which is now fixed.
- Have DAnalysisSessionImpl.Saver registration/unregistration for both
ResourceSetListener and Lifecycle in constructor/dispose().
- Have DAnalysisSessionImpl.removeAdaptersOnAnalysis() remove
SemanticResourcesUpdater as it is added in
DAnalysisSessionImpl.addAdaptersOnAnalysis()

Bug: 452962
Change-Id: I8942bdd7168f4cc3c5981dd0b5c2c4b438ac0359
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
[440954] change ValidationRule Annotation Type

in viewpoint.ecore, returnType of ValidationRule.message feature is now
typed String

Bug 440954
Change-Id: I71d4b5be6e4cc32fa819a1dd8520440faa5372aa
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
[test] Cleanup tests by disabling snapToGrid.

This avoids to use PointAround.around matcher and allow to use an
assertEquals instead.

Change-Id: If78d8c5f876350284b7d0256df1170c8ef729446
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[test] Change data to avoid potential problem caused by Fonts

The test UmlPortMoveTest.testMovePortOnNodeInContainer() is KO on Hudson
Sirius but OK locally. This commit just changes some bounds to avoid
size computated from size of Fonts.

Change-Id: Iefc812d541e4a091b421041b55f5c5ca6692cd4e
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[test] Add a delta of 1 for GMF bendpoints.

The result is different locally and on Hudson. This delta allows some
failures caused by round problem.

Change-Id: I6394b4556702bdc1dfd2ecbf396a32edba3b4412
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[452962] Adapt SessionWorkspaceSyncTests test since cleanup on session
close

Bug: 452962
Change-Id: I1e82aee069c747a52de68f7f6c202f6dc6a16937
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
[454241] Avoid memory leak on layout provider

Make
ArrangeSelectionLayoutProvider/AbstractLayoutProvider/InlineEdgeLayoutProvider
not keep references to EditParts
after layout call.

Bug: 454241
Change-Id: Ib18da34dba2365a81fc020b2349923a93849d1cb
Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
[454454] Remove java nature for oes.samples.family project

and clean corresponding settings.

Bug: 454454
Change-Id: I8550c8e85fb93534d8dd4180c0638fca0cc1ac42
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[454454] Fix Tycho build problem.

The build failed, caused by missing sources for plugin
org.eclipse.sirius.samples.family. The folder "samples" has been added
as source.

The jdt prefs has also been removed because it is useless since the
previous commit for bug 454454.

Bug: [454454]
Change-Id: I7a125c634e80f43749c82a286dd9092405cdee28
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[453036] Remove obselete test.

* This test was testing that a warning is launched within the error log
when attempting to reconnect an edge without the expected reconnect
source or target. But since this fix[1], the command doesn't fail. The
specifier could create a reconnect tool with a different behavior than
reconnect the source or the target as expected by the feedback.

[1]
http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=aa71fd0455b1bdaea07dee635ede6b09d9a7c146

Bug: 453036
Change-Id: I28e3eb74921cad8b546aebeb379456ba197ab3f4
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
[454573] fix some documentation typo errors

Bug: 454573
Change-Id: I898cdf38017cfc97b68b34aa34796ac0c72224f2
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
Revert "[452962] Improve Session resources cleanup on close      - clear
DAnlysisSessionEObject.activatedViewpoints to avoid potential Viewpoint
reloading on proxy resolution. - Give Session in constructor of
RepresentationNameListener to avoid get Session from SessionManager. -
Remove useless try/catch NPE in RepresentationsChangeAdapter as it was
for a CDO bug which is now fixed. - Have DAnalysisSessionImpl.Saver
registration/unregistration for both ResourceSetListener and Lifecycle
in constructor/dispose(). - Have
DAnalysisSessionImpl.removeAdaptersOnAnalysis() remove
SemanticResourcesUpdater as it is added in
DAnalysisSessionImpl.addAdaptersOnAnalysis()"

This reverts commit 29322aa34cf733e96ea27364c38f8686dd66c43c. This
commit causes regression on JUnit tests. It is reverted while waiting to
find a solution.

Bug: 452962
Change-Id: I0c90cfb16c9b208506fc8964b9c79667f5aada9c
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
[cleanup] Set session to null after SaveSessionJob execution

After a memory analysis, we have noticed that several AirDResourceImpl
are retained by DAnalysisSessionImpl, that themselves are retained by
SaveSessionJob. The job can indeed, be retained by ProgressManager.
The session is now reset to null after the job execution. Even if Job is
supposed to be reusable (see Javadoc of Job), the SaveSessionJob do
nothing if it is reused.

Change-Id: Ic9971c486e80d54ba185c69895bf926453d1f692
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>