Merge pull request #679 from voidspace/waitfor-replicaset

Remove the Remove

replicaset/replicaset_test : get rid of extraneous calls to Remove

Remove is a slow operation, and we're seeing spurious failures in CI here. We create a bunch of mongo instances and defer removing them from the replicaset. We destroy them immediately after removal, and then destroy the root, so the Remove is extraneous. This should improve test reliability.
Add a backups abstraction.
Add Create() to the backups abstraction.
cmd/jujud: avoid duplicate code for counting upgrade attempts in upgrade tests
cmd/jujud: avoid duplication in the 2 "success" upgrade test cases
cmd/jujud: shorten upgrade test helper names

Makes the tests a little more readable.
cmd/jujud: rationalise machine & config handling in upgrade tests

These tests have always been a bit confusing because machine-0 and its
config were being stored on the test suite, with various helper
methods magically using them as required. Data associated with other
machines have always been stored in local variables and passed around.

This change makes the data for machine-0 be handled consistently. This
makes for more explicit, clearer tests and has allowed for various
cleanups.
Merge branch 'master' into lp-1336843-wo-jenv-destroy-env
Use values instead of pointers.
Add missing blank lines before comments.
Drop unnecessary type declaration.
Add tests for failure cases.
Mock out lumberjack config for tests.
Update to latest juju/testing.
Merge pull request #720 from howbazaar/update-juju-testing

Update to latest juju/testing.
Update blobstore rev

Fixes https://bugs.launchpad.net/juju-core/+bug/1367431
Change state.User to take a names.UserTag
Merge pull request #722 from axw/master

Update blobstore rev

Fixes https://bugs.launchpad.net/juju-core/+bug/1367431
Merge pull request #717 from howbazaar/jujud-test-fixes

Mock out lumberjack config for tests.

Drive by also adds a few extra logging bits.
Changed a fmt.Printf to a c.Log to avoid extra test noise.
Increment juju to 1.21-alpha2