add test for controller