controller generator almost done