PFS & ACG updates

This should resolve the merge problem as long as no other PR's that change the files that this changes are pulled in when based upon a much older master.
These changes had to do with inconsistent naming by whomever entered it originally. Bloodrager class has “Bloodline” and “Bloodline Power” class features. It could very well be that some of them were named in a way that was conflicting with other abilities. I don’t remember the actual cause, I was just one-by-one going through PCGen error log and fixing all the unconstructed and duplicate kind of errors that I could fine with this source. The “Bloodlines” selection “Elemental” has 4 choices “Air”, “Earth”, etc. Each the archetypes abilities operate on the elemental choice. So to make sure that these keys are completely separate from any other Special Ability keys that might be called “Elemental ~ Air” I made sure these abilities were in the format of “Crossblooded Rager Power x ~ y” where x is part of the archetype’s ability name (like Movement for Elemental Movement) and y is the elemental choice.

 

This is not set in stone. If there is some other standard naming convention, like including two “ ~ ” separators in the key, it can certainly be changed again. But for now the unconstructed references and key naming style mismatches within this archetype are solved.

 

Mark

 

 

From: Andrew Maitland [mailto:notifications@github.com] 
Sent: Thursday, October 23, 2014 7:27 PM
To: PCGen/pcgen
Cc: mjmeans
Subject: Re: [pcgen] PFS & ACG updates (#121)

 

In content/notfordistribution/pathfinder/paizo/roleplaying_game/advanced_class_guide/acg_abilities_class.lst:

> -Elemental Movement  KEY:Crossblooded Rager Power Elemental Movement ~ Earth          CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:You gain a burrow speed of 30 ft.                                                                                                                                                                                                                                                                                    MOVE:Burrow,30                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               SOURCEPAGE:p.21
> -Elemental Movement  KEY:Crossblooded Rager Power Elemental Movement ~ Fire           CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:Your base speed increases by 30 ft.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       BONUS:MOVEADD|TYPE.Walk|30                                                                                                                SOURCEPAGE:p.21
> -Elemental Movement  KEY:Crossblooded Rager Power Elemental Movement ~ Water          CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:You gain a swim speed of 60 ft.                                                                                                                                                                                                                                                                                    MOVE:Swim,60                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 SOURCEPAGE:p.21
> -Power of the Elements       KEY:Crossblooded Rager Power Power of the Elements ~ Air            CATEGORY:Special Ability TYPE:BloodragerClassFeatures                                                                                          DESC:The electricity damage done by your elemental strikes ability bypasses electricity resistance, and still deals half damage to creatures with immunity to electricity.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         SOURCEPAGE:p.21
> -Power of the Elements       KEY:Crossblooded Rager Power Power of the Elements ~ Earth               CATEGORY:Special Ability TYPE:BloodragerClassFeatures                                                                                          DESC:The acid damage done by your elemental strikes ability bypasses acid resistance, and still deals half damage to creatures with immunity to acid.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 SOURCEPAGE:p.21
> -Power of the Elements       KEY:Crossblooded Rager Power Power of the Elements ~ Fire           CATEGORY:Special Ability TYPE:BloodragerClassFeatures                                                                                          DESC:The fire damage done by your elemental strikes ability bypasses fire resistance, and still deals half damage to creatures with immunity to fire.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 SOURCEPAGE:p.21
> -Power of the Elements       KEY:Crossblooded Rager Power Power of the Elements ~ Water               CATEGORY:Special Ability TYPE:BloodragerClassFeatures                                                                                          DESC:The cold damage done by your elemental strikes ability bypasses cold resistance, and still deals half damage to creatures with immunity to cold.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 SOURCEPAGE:p.21
> -Elemental Body              KEY:Crossblooded Rager Power Elemental Body ~ Air                    CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:Elemental power surges through your body. You gain immunity to sneak attacks, critical hits, and electricity damage. You have this benefit constantly, even while not bloodraging.                                                                                                                                          ABILITY:Special Ability|AUTOMATIC|Immunity to Electricity                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         SOURCEPAGE:p.21
> -Elemental Body              KEY:Crossblooded Rager Power Elemental Body ~ Earth                  CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:Elemental power surges through your body. You gain immunity to sneak attacks, critical hits, and acid damage. You have this benefit constantly, even while not bloodraging.                                                                                                                                                ABILITY:Special Ability|AUTOMATIC|Immunity to Acid                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                SOURCEPAGE:p.21
> -Elemental Body              KEY:Crossblooded Rager Power Elemental Body ~ Fire                   CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:Elemental power surges through your body. You gain immunity to sneak attacks, critical hits, and fire damage. You have this benefit constantly, even while not bloodraging.                                                                                                                                                ABILITY:Special Ability|AUTOMATIC|Immunity to Fire                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                SOURCEPAGE:p.21
> -Elemental Body              KEY:Crossblooded Rager Power Elemental Body ~ Water                  CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:Elemental power surges through your body. You gain immunity to sneak attacks, critical hits, and cold damage. You have this benefit constantly, even while not bloodraging.                                                                                                                                                ABILITY:Special Ability|AUTOMATIC|Immunity to Cold                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                SOURCEPAGE:p.21
> +Elemental Movement          KEY:Crossblooded Rager Power Elemental Movement ~ Air                    CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:You gain a fly speed of 60 ft. with average maneuverability.                                                                                                                                                                                                                                                          MOVE:Fly,60                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         SOURCEPAGE:p.21
> +Elemental Movement          KEY:Crossblooded Rager Power Elemental Movement ~ Earth          CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:You gain a burrow speed of 30 ft.                                                                                                                                                                                                                                                                                    MOVE:Burrow,30                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               SOURCEPAGE:p.21
> +Elemental Movement          KEY:Crossblooded Rager Power Elemental Movement ~ Fire           CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:Your base speed increases by 30 ft.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       BONUS:MOVEADD|TYPE.Walk|30                                                                                                                SOURCEPAGE:p.21
> +Elemental Movement          KEY:Crossblooded Rager Power Elemental Movement ~ Water          CATEGORY:Special Ability        TYPE:BloodragerClassFeatures.SpecialQuality.Supernatural                                                           DESC:You gain a swim speed of 60 ft.                                                                                                                                                                                                                                                                                    MOVE:Swim,60                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 SOURCEPAGE:p.21
> +Power of the Elements       KEY:Crossblooded Rager Power of the Elements ~ Air            CATEGORY:Special Ability TYPE:BloodragerClassFeatures                                                                                          DESC:The electricity damage done by your elemental strikes ability bypasses electricity resistance, and still deals half damage to creatures with immunity to electricity.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        SOURCEPAGE:p.21

I'm trying to understand this change - We added a tab and removed the Naming element to break with proper name?
Just making sure you see what I'm seeing. Everything in this section to maintain consistency is "Crossblooded Rager Power" and then the other portion of the name since if we used the original we'd be overriding a real class feature. So why have we renamed "Power of the Elements ~ x" to "of the Elements ~ x'?

—
Reply to this email directly or view it on GitHub <https://github.com/PCGen/pcgen/pull/121/files#r19320539> .  <https://github.com/notifications/beacon/ADyap_UB3C4z7W0DRmSDd9ORbu6SV-G7ks5nGbB6gaJpZM4CydbT.gif>