Where is that logic?

As I mentioned, in my test, I had two users, A and B.  B was on A's roster
from previous testing.  B friended A, but A never saw a friend suggestion
for B until they both ran Lantern at the same time, which I'm assuming came
from the presence notification.  If B was supposed to show up, perhaps
something was broken?


Cheers,
Ox

-----------------------------------------------------------------------------------------

"I love people who harness themselves, an ox to a heavy cart,
who pull like water buffalo, with massive patience,
who strain in the mud and the muck to move things forward,
who do what has to be done, again and again."

- Marge Piercy



On Sun, Jan 12, 2014 at 6:23 PM, myleshorton <notifications@github.com>wrote:

> In src/main/java/org/lantern/friending/Friending.java:
>
> > -                        return success(quota, friends);
> > +                        Set<Friend> uniqueFriends = new HashSet<Friend>(friends);
> > +                        // Find friend relationships referencing this user and add them
> > +                        // to the set of unique Friends as free to friend
> > +                        List<LanternFriend> reverseFriends = new Dao()
> > +                                .withObjectify(new DbCall<List<LanternFriend>>() {
> > +                                    @Override
> > +                                    public List<LanternFriend> call(Objectify ofy) {
> > +                                        return ofy.query(LanternFriend.class)
> > +                                                .filter("email", userEmail)
> > +                                                .filter("status", Status.friend)
> > +                                                .list();
> > +                                    }
> > +                                });
> > +                        for (Friend friend : reverseFriends) {
> > +                            uniqueFriends.add(new LanternFriend(friend.getUserEmail(), userEmail, Status.pending, true));
>
> Wait, we already show those users because they're Lantern users who are on
> your roster though right?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/getlantern/lantern-controller/pull/59/files#r8816160>
> .
>