working on angular generators review