Issue 336 2

These patches consolidate the parse of command line options to ConfigManager.
In addition, it also parses a configuration file.
> What do you think about this comment?

I agree with you and I'm working on that.


2014-08-12 16:26 GMT+09:00 Kouhei Sutou <notifications@github.com>:

> In server/src/ConfigManager.cc:
>
> > +			g_set_error(error, quak, CONF_MGR_ERROR_NULL,
> > +			            "value is NULL.");
> > +			return FALSE;
> > +		}
> > +		int port = atoi(value);
> > +		if (!Utils::isValidPort(port, false)) {
> > +			g_set_error(error, quak, CONF_MGR_ERROR_INVALID_PORT,
> > +			            "value: %s, %d.", value, port);
> > +			return FALSE;
> > +		}
> > +
> > +		obj->faceRestPort = port;
> > +		return TRUE;
> > +	}
> > +};
> > +static CommandLineOptions g_cmdLineOpts;
>
> What do you think about this comment?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/project-hatohol/hatohol/pull/365/files#r16098891>.
>