Add code quality test for self assignments

> because you have a return as the only statement in a while loop

Oh, indeed.  forgot to change while -> if

> 2) if we don't assign to self, we should probably not assign to other?

Why?