Out of curiosity what happens if you pass in something nonsensical? Does it
just throw a 500? I would do it just because it feels a little dirty as is.

On Thu Jan 23 2014 at 9:59:25 AM, Ace Nassri <notifications@github.com>
wrote:

> In liquid/corporate/resume/views.py:
>
> > @@ -154,11 +160,20 @@ def recruiter_browse(request):
> >    else:
> >      people = set.get_people()
> >
> > -  num_per_page = request.GET.get('num_per_page')
> > -  if num_per_page==None:
> > -    num_per_page = 50
> > +  # Sortable tables
> > +  sort_field = request.GET.get("sort_field")
> > +  sort_dir = request.GET.get("sort_dir")
> > +
> > +  if sort_field == None:
> > +    sort_field = "name"
> > +  if sort_dir == None:
> > +    sort_dir = ""
>
> I debated that, but I was assuming that users wouldn't do that expecting
> it to work and that it wouldn't really be a security hole. I can add this
> though,
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/acm-uiuc/liquid/pull/191/files#r9122072>
> .
>