fixed attr update