Make remove_volume_connection() use objects

Changes the remove_volume_connection() method in compute manager
to take objects.

Related to blueprint compute-manager-objects-juno

Change-Id: I4fabee87df409accd947db3d5b429f7e871c2d60
VMware: create utility function for reconfiguring a VM

A utility method has been created that simplifies the process of
reconfiguring a VM.

Change-Id: I184e2483726e29819164175493cfd1559592358b
Update compute rpcapi tests to use instance object instead of dict

Bugs such as 1327145 when the rpc code is accidentally reverted
to passing dicts instead of objects are not currently detected by
the unit tests because these are always called with a dict.

This change updates all compute rpcapi unit test cases to pass
an instance object to all cases where the version has been
converted to objects, so that such issues are now detected.

Related to blueprint compute-manager-objects-juno

Change-Id: I9b974e3a8e8e6dcbf87b1bdc854f05e94e7a35ce
vmwareapi: remove unused update_host_status method

The VMWare driver declares a method 'update_host_status'
which has no callers anywhere in the codebase.

This is left over code that was missed in the cleanup from

  commit 2cb47fbabf09ced76178e8453d508c66f86a7a3a
  Author: Arata Notsu <notsu@virtualtech.jp>
  Date:   Thu Oct 18 22:40:01 2012 +0900

    Remove ComputeDriver.update_host_status()

Partial-bug: #1333219
Change-Id: Ie0de9b6d427246cb3c3adb818d483b61dfb08d82
virt: add get_instance_disk_info to virt driver API

The compute manager has been calling get_instance_disk_info on
virt driver implementations during block migration, despite
this method not being declared in the virt driver API. It was
implemented in libvirt and stubbed in xenapi, with different
API signatures in both.

Declare & document it as part of the virt driver API, and
split the libvirt impl into two parts to hide the libvirt
specific notion of XML config.

Partial-bug: #1333219
Change-Id: I38c811f91cce99772ff988a278c32483a219949d
ConfigDriveBuilder refactor for tempdir cleanliness

In looking to clean up excessive DEBUG logging, it became clear
that the logging in ConfigDriveBuilder was largely based on the
split logic that existed in doing fs opts in __init__ and then
also later in make_drive. This required a persistent tempdir, which
had to be manually cleaned up. It also meant a mandatory additional
config variable.

Refactor ConfigDriveBuilder to move all fs opts into make_drive,
deprecating the config variable in the process. In doing so, I don't
believe the previous debug logging is useful any more. However, in
case, add a __repr__ for ConfigDriveBuilder that will provide us with
a reasonable debug representation in case this becomes part of what
gets thrown.

Tests are now adjusted to not call private methods, but instead call
make_drive with config variable set.

Change-Id: I1aaf194fef00edd6eecf73b5bb9323e0e3a6f09f
sync policy logging fix from incubator

This change syncs in a delete of an extremely verbose tight loop
debug message in policy.py that generated 8 additional lines for
every wsgi call.

Changes:

238e601b Make policy debug logging less verbose
9c88dc31 file_open: fixed docstring to refer to open() instead of file()

Change-Id: Ifd3f139ebabec9db4a645cd092a810ab22f5085e
Updated from global requirements

Change-Id: I51682a7a4b46a88598639c0e779857537dbc2e2c
Merge "Update compute rpcapi tests to use instance object instead of dict"
Avoid re-adding iptables rules for instances that have disappeared

The remove_filters_for_instance() method fails silently if the
instance's chain is gone (i.e. it's been deleted). If this
happens while we're refreshing security group rules, we will
not notice this case and re-add stale rules for an old instance,
breaking our firewall for new instances.

This adds a quick check after we've captured the lock to see if
the associated chain exists, and bails if it doesn't.

Change-Id: Ic75988939f82de49735d85fe99a9eecd4baf45c9
Related-bug: #1182131
Merge "VMware: create utility function for reconfiguring a VM"
Merge "vmwareapi: remove unused update_host_status method"
Merge "Avoid re-adding iptables rules for instances that have disappeared"
Merge "Make remove_volume_connection() use objects"
Merge "Updated from global requirements"
Merge "virt: add get_instance_disk_info to virt driver API"
Merge "ConfigDriveBuilder refactor for tempdir cleanliness"
Merge "sync policy logging fix from incubator"