I see.
The difference between those two lines is that the first one uses a string literal to append something to the node value, so interpolation makes sense there.
The second one doesn't, so wrapping in a string literal and interpolating is wasteful.

Thanks for fixing this, looks good otherwise.

From: Imran Ahmed <notifications@github.com<mailto:notifications@github.com>>
Reply-To: aws/opsworks-cookbooks <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: 2014-04-17 at 23:16
To: aws/opsworks-cookbooks <opsworks-cookbooks@noreply.github.com<mailto:opsworks-cookbooks@noreply.github.com>>
Cc: Huesch Daniel <huesch@amazon.de<mailto:huesch@amazon.de>>
Subject: Re: [opsworks-cookbooks] Add support for node env for express (#115)


In deploy/definitions/opsworks_nodejs.rb:

> @@ -30,7 +30,8 @@
>      variables(
>        :deploy => deploy,
>        :application_name => application,
> -      :monitored_script => "#{deploy[:deploy_to]}/current/server.js"
> +      :monitored_script => "#{deploy[:deploy_to]}/current/server.js",
> +      :node_env => "#{node.default[:deploy][application][:node_env]}"


String Literal : Just duplicated the line above.

node.default : it wasn't an intentional choice. I will fix :)

—
Reply to this email directly or view it on GitHub<https://github.com/aws/opsworks-cookbooks/pull/115/files#r11764732>.