Ticket #47809 - find a way to remove replication plugin errors messages "changelog iteration code returned a dummy entry with csn %s, skipping ..."

Description:
1) Can't locate CSN %s in the changelog (DB rc=%d).
   Print the message once per one missing CSN.
2) changelog iteration code returned a dummy entry with csn %s, skipping ...
   Downgrade the log level to replication log level (SLAPI_LOG_REPL).

https://fedorahosted.org/389/ticket/47809

Reviewed by rmeggins@redhat.com (Thanks, Rich!)
Ticket 47602 - txn commit being performed too early

Bug Description:  The transaction is committed too early, and this leads to
                  a deadlock when accessing the retro changelog.

Fix Description:  Move the commit after we are done using the txn(id2entry, etc).

https://fedorahosted.org/389/ticket/47602

Reviewed by: nhosoi(Thanks!)
Ticket 47815 - Add operations rejected by betxn plugins remain in cache

Bug Description:  When an add operation is rejected by a betxn post plugin
                  the "adding" entry is removed the cache(previously added
                  tentatively), it gets re-added back to the entry cache
                  when we call betxn post plugins just before the abort.

Fix Description:  Remove the entry from the cache when the 2nd run of
                  the betxn postop plugins fails(just before we abort
                  the transaction).

https://fedorahosted.org/389/ticket/47815

valgrind: passed
jenkins: passed

Reviewed by: nhosoi(Thanks!)
Ticket 47810 - investigate betxn plugins to ensure they
 return the correct error code

Bug Description:  Prior to backend transaction plugin types, postop error
                  codes didn't really have an effect, so often times a success
                  result was implicitly being returned.

Fix Description:  Alawys return the correct error code for all backend transaction
                  plugins.

https://fedorahosted.org/389/ticket/47810

Jenkins: Passed
TET: Passed

Reviewed by: nhosoi(Thanks!)
Ticket 47817 - The error result text message should be obtained just prior to sending result

Bug Description:  We do not get pblock result message after the betxn postop plugins
                  are called.  If a betxn plugin modified the ldap result message, then
                  when the backend returns the results it does an invalid read on the
                  old pointer of the old result message.

Fix Description:  Get the result message after we call the betxn postop plugins.

https://fedorahosted.org/389/ticket/47817

jenkins: passed

Reviewed by: nhosoi(Thanks!)
fix coverity issue 12621

reviewd by Nathan, thanks
fix compiler error with alst coverity commit
Ticket 47827 - online import crashes server if using verbose error logging

Bug Description:  When using verbose logging and running an import task, the
                  server will crash at the end of the import.  The verbose
                  logging changes the internal timing and exposes a race condition
                  where the task queue frees the import job before the import
                  finishes.

Fix Description:  Wait for the backend instance to be set as "not busy" before
                  freeing the import task.

https://fedorahosted.org/389/ticket/47827

Reviewed by: nhosoi(Thanks!)
Ticket 47815 - add lib389 test

Description:  Add a lib389 test for ticket 47815

https://fedorahosted.org/389/ticket/47815

Reviewed by: nhosoi(Thanks!)
Ticket #47831 - server restart wipes out index config if there is a default index

https://fedorahosted.org/389/ticket/47831
Reviewed by: nhosoi (Thanks!)
Branch: master
Fix Description: In ldbm_instance_index_config_enable_index(), only call
the function ldbm_index_parse_entry() if the index does not exist.  Instead,
get the name of the index from the "cn" attribute of the entry, and use
ainfo_get() to get the index.  If this returns NULL, then call
ldbm_index_parse_entry() to create and parse the index.
Platforms tested: Fedora 20
Flag Day: no
Doc impact: no
Ticket #555 - add fixup-memberuid.pl script

Description: add fixup-memberuid.pl to Makefile.am

https://fedorahosted.org/389/ticket/555

Reviewed by nhosoi@redhat.com
Ticket #555 - add fixup-memberuid.pl script

Description: add fixup-memberuid.pl script

https://fedorahosted.org/389/ticket/555

Reviewed by nhosoi@redhat.com
Ticket #555 - add fixup-memberuid.pl script

Description: Thanks to Carsten Grzembra for providing us the script
(previous 2 commits -- add fixup-memberuid.pl)
This is an additional patch generated by the autogen.sh.

https://fedorahosted.org/389/ticket/555
Ticket 47821 - deref plugin cannot handle complex acis

Bug Description:  the deref plugin does not return attributes if
			the access depends on rules requireing
			the entry

Fix Description:   do the access check after the entry is retrieved

https://fedorahosted.org/389/ticket/47821

Reviewed by: mark, thanks
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing

Bug description: https://fedorahosted.org/389/ticket/47750#comment:16

Fix description: The logic in slapi_is_special_rdn to check if the
RDN is a tombstone or not had a problem.  Even if the first part of
RDN is not nsuniqueid=<UNIQUE_ID>, it was returning true.  In this
patch, code to check the case is added and it returns false if the
first part of RDN is not  nsuniqueid=<UNIQUE_ID>.

Reviewed by mreynolds@redhat.com and rmeggins@redhat.com (Thank you,
Mark and Rich!!)
Ticket 47808 - If be_txn plugin fails in ldbm_back_add, adding entry is double freed

Bug Description:
	CI test fix
		- commented the py.test fixture
		- unset installation_prefix

https://fedorahosted.org/389/ticket/47808

Platforms tested: F19 jenkins

Flag Day: no

Doc impact: no
Ticket 47815 - Add operations rejected by betxn plugins remain in cache

Bug Description:

	CI test miss '@' in fixture declaration

https://fedorahosted.org/389/ticket/47815

Platforms tested: F19 jenkins

Flag Day: no

Doc impact: no
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing

Description: This commit accidentally removed the code to decrementing
the reference count for the backend instance.
  Commit: 160cb3f686e433c01532d28770b2977ec957e73e
  Ticket #47750 - Creating a glue fails if one above level is a conflict or missing;
Thanks to mreynolds@redhat.com for finding this out.
Ticket #47763 - winsync plugin modify is broken

Description: Thanks to Carsten Grzemba for the patch.  Made minimum
changes such as replacing the direct access to the bv_len in Slapi_Value
with slapi_value_get_length.

Note: Regarding attr_compare_equal, since there is no strong reason
to switch to this new attr_compare_equal, we continue using the original
code.  The newly provided code is in "#if 0".

https://fedorahosted.org/389/ticket/47763

Reviewed by rmeggins@redhat.com (Thanks, Rich!)
Ticket #47835 - Coverity: 12687..12692

12692 - Use of untrusted string value
Description: lines read from the sysconfig reload task's attribute
sysconfigfile (e.g., /etc/sysconfig/dirsrv-localhost) could be tainted.
Check the end of the line more rigorously, and eliminate a chance to
overflow env_var and env_value by copying the characters from read
line.

Reviewed by rmeggins@redhat.com (Thanks, Rich!)

https://fedorahosted.org/389/ticket/47835