datapath: Add additional port states

Currently a vport can be in one of two states - enabled or disabled.
This does not account for additional states, like a vport that was
previously added (and initialised) but has since been disabled. Extend
this to include additional states, like the aforementioned added but
disabled state.

Change-Id: I582b942e2eeae03ea6c0dcde45405c2ef6aea759
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
dpif-dpdk: Implement new datapath port state

Firstly, when adding a port, check if the port has been previously
added, by checking the lcoreid value associated with the port. If set
to a valid value, the port exists and merely needs to be re-enabled.
If not, the port does not exist and must be added and enabled.

Secondly, when deleting a port, ensure that both in-ports *and*
out-ports are deleted.

Change-Id: I8c0982b2f10b11ae9f408aa4db08c973ffbe23bf
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
tests: Add additional tests for new states

Add tests to validate the port state changes.

In addition, add an utils file for common test code.

Change-Id: I68a29228f3e9668ee3e073d56decd8de03b825f9
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Mark B. Kavanagh <mark.b.kavanagh@intel.com>
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Ciara Loftus <ciara.loftus@intel.com>
docs: Remove resolved issue

Change-Id: I9863e3147a463d0341abff643042667efb9bd3ac
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
NEWS.md: Update for port delete bugfix

Change-Id: I6c507dbad064c1621d97652a67e1205945e0f9f2
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>
dpif: use VLOG only in dpdk_link

dpdk_link.c currently uses a combination of VLOG_ and RTE_LOG_
macros for logging. Remove all RTE_LOG_ macros, and replace with
VLOG_ macros.

Change-Id: I1c351b49f28cb229e4d69740d3acfcf7a39ee4d9
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
Reviewed-By: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-By: Kevin Traynor <kevin.traynor@intel.com>
Update bug report addresses

Update Open vSwitch code to point bug reports to
Intel (r) DPDK vSwitch list

Signed-off-by: Mark D. Gray <mark.d.gray@intel.com>
Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Change-Id: I2c01aea03405cb980ef7708ff01f1d67900872db
tests: Fix file permissions

Change-Id: Ia1b750bf2a359ca412e37220fde8c4413ffdabba
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Kevin Traynor <kevin.traynor@intel.com>