Make Scaladoc actually exit with non-zero exit code in case of errors, as its docs say it does

I did this work for Twitter, on Twitter's time, so I'm covered under Twitter's CLA. 

Fixes #4031.
I'd retweet this if there were a button.  T/F is never enough.