https://github.com/edx/edx-platform/blob/dhm/mixed_ms_converter/common/lib/xmodule/xmodule/modulestore/mixed.pyshows
that I've made this change in the next pr being built. I haven't
cleanly separated the converters out further yet tho.


On Mon, Feb 10, 2014 at 10:08 AM, Calen Pennington <notifications@github.com
> wrote:

> In common/lib/xmodule/xmodule/modulestore/mixed.py:
>
> >          """
> >          super(MixedModuleStore, self).__init__(**kwargs)
> >
> >          self.modulestores = {}
> >          self.mappings = mappings
> > +        # temporary code for transition period
> > +        if reference_type is None:
> > +            log.warn("reference_type not specified in MixedModuleStore settings. %s",
> > +                "Will default temporarily to the to-be-deprecated Location.")
> > +        self.use_locations = (reference_type != 'Locator')
>
> I think you could clean up a bunch of the code, rather than storing a
> boolean for use_locations, you stored the reference type base class (as a
> class), and then used issubclass elsewhere in the code. Then you could
> basically just ask whether the current type is a subclass of the reference
> type, and if so, skip any conversion, otherwise, pick the appropriate
> conversion.
>
> However, I don't think that needs to happen before this PR gets merged.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/2356/files#r9586479>
> .
>