I committed yours 2 recommendations.
it looks like they automatically appear in the PR.
I guess that is the idea.

Fred.



On Tue, Jan 21, 2014 at 7:59 PM, Frederic Torres <fredericaltorres@gmail.com
> wrote:

> Making your recommendation.
>
> but
> passing null to string.search() must be converted into "null"
>  "null".search(null) === 0
>
>
> On Tue, Jan 21, 2014 at 7:52 PM, Sébastien Ros <notifications@github.com>wrote:
>
>> In Jint/Native/String/StringPrototype.cs:
>>
>> > @@ -234,6 +353,16 @@ private JsValue Search(JsValue thisObj, JsValue[] arguments)
>> >              var s = TypeConverter.ToString(thisObj);
>> >
>> >              var regex = arguments.At(0);
>> > +
>> > +            if (regex.IsUndefined())
>> > +            {
>> > +                regex = string.Empty;
>> > +            }
>> > +            else if (regex.IsNull())
>> > +            {
>> > +                regex = Null.Text;
>>
>> Haven't looked at the spec, but it's really the "null" string that you
>> want to return, not the Null value ?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/sebastienros/jint/pull/3/files#r9061667>
>> .
>>
>
>