You could have taken the opportunity to fix their misspelling, too. :-)

NTL is GPLv2 or later, so that's okay with what we do.

But let's not patch Singular unless there's no way around it to get it to
work.  In particular, let's not
patch their error messages.


On Wed, Mar 5, 2014 at 5:33 AM, jakobkroeker <notifications@github.com>wrote:

> In M2/Macaulay2/e/x-factor.cpp:
>
> > @@ -225,13 +225,13 @@ static const RingElement * convertToM2(const PolynomialRing *R, CanonicalForm h)
> >
> >      // debugging display routines to be called from gdb
> >      // needs factory to be configured without option --disable-streamio
> > -#if 1
> > -void showvar(Variable &t) { cout << t << endl; }
> > -void showcf(CanonicalForm &t) { cout << t << endl; }
> > -void showcfl(CFList &t) { cout << t << endl; }
> > -void showcffl(CFFList &t) { cout << t << endl; }
> > -void showmpint(gmp_ZZ p) { mpz_out_str (stdout, 10, p); cout << endl; }
> > -void showmpz(mpz_t p) { mpz_out_str (stdout, 10, p); cout << endl; }
> > +#if 0
>
>  i1 : ZZ/2[t]; i2 : isPrime(t^2+t+1) uniivariate factorization not
> implemented
>
> this is caused by undetected NTL by
> factory. Should we patch factory in a way that NTL is mandatory?
>
> I'm hesitant to patch,
>
> then we could patch Singular directly (at least improve the error message):
> Singular/Sources#530 <https://github.com/Singular/Sources/pull/530>
>
> Now I also recall that we can't define NTL mandatory without restricting
> the M2 licensing model.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Macaulay2/M2/pull/108/files#r10294402>
> .
>