switched to using shared examples for has_many spec