On 13 Jan, 2014, at 2:01 PM, Chris Jones <notifications@github.com> wrote:

> In DataFormats/Common/interface/DetSet.h:
> 
> > @@ -51,7 +51,7 @@
> >      
> >      DetSet<T> & operator=(DetSet<T> && rh)  noexcept {
> >        id = rh.id;
> > -      data.swap(rh.data);
> > +      data = std::move(rh.data);
> 
> @VinInn Vincenzo, are there any other classes which are elements of DetSet which which do not have move op=?
I think DetSet is no used only by PixelDigi. Everybody else uses DeSetNew.
> I ask since if there are you probably made a pessimistic optimization replacing a swap with a copy.
Havent seen any regression in Reco. If they exist,  need to be fixed. (btw since each DetSet is sorted duing event put if T is not movable will show up there more than here)
> I think the standard has some meta programming checks for the various move functions.
Indeed. the nastier being missing “noexcept”

v.