Hi Gustavo,

Point taken regarding the transients list.
I don’t see your point on API changes with a new genome release (not that often). The enumeration class need to be updated, not the API. Or is that what you mean?

Regards,
Wim.

From: Gustavo Lopes [mailto:notifications@github.com]
Sent: Tuesday 22 April 2014 2:43 PM
To: thehyve/transmart-core-db
Cc: Linden, Wim van der
Subject: Re: [transmart-core-db] Change de_gpl_info.release_nbr to string (FT-749 + FT-751) (#34)


In grails-app/domain/org/transmartproject/db/dataquery/highdim/DeGplInfo.groovy:

> @@ -35,4 +38,9 @@ class DeGplInfo implements Platform {

>      Iterable<?> getTemplate() {

>          throw new NotYetImplementedException()

>      }

> +

> +    @Override

> +    GenomeBuildNumber getGenomeBuildNumber() {

> +        GenomeBuildNumber.forId releaseNumber

> +    }

This field should be in transients list because it shouldn't be saved, but I also think it shouldn't exist at all. I don't think it makes sense to have an API that has to be changed each time there's a new genome release. The string is enough.

—
Reply to this email directly or view it on GitHub<https://github.com/thehyve/transmart-core-db/pull/34/files#r11850159>.

________________________________
The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.