Incorrect sandbox_check in RemoteInspector.mm
https://bugs.webkit.org/show_bug.cgi?id=138408

Reviewed by Joseph Pecoraro.

* inspector/remote/RemoteInspector.mm:
(Inspector::canAccessWebInspectorMachPort):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Disable interaction with action menu page previews
https://bugs.webkit.org/show_bug.cgi?id=138400

Patch by Conrad Shultz <conrad_shultz@apple.com> on 2014-11-05
Reviewed by Tim Horton.

Expand on the existing -[WKView shouldIgnoreMouseEvents] by adding facilities to suppress handling
of all non-wheel events, effectively creating a scroll-only web view. Deploy this in
WKPagePreviewViewController.

* UIProcess/API/Cocoa/WKViewPrivate.h:
Declare the OS X-only ignoresNonWheelMouseEvents SPI.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _ignoresNonWheelMouseEvents]):
(-[WKWebView _setIgnoresNonWheelMouseEvents:]):
Wrap the underlying WKView methods.

* UIProcess/API/Cocoa/WKWebViewInternal.h:
Declare the OS X-only ignoresNonWheelMouseEvents property.

* UIProcess/API/mac/WKView.mm:
Add _ignoresNonWheelMouseEvents to WKViewData.
(-[WKView shouldIgnoreMouseEvents]):
Include a check for _ignoresNonWheelMouseEvents.
(-[WKView _setIgnoresNonWheelMouseEvents:]):
Set the ivar in WKViewData.
(-[WKView _ignoresNonWheelMouseEvents]):
Fetch the ivar in WKViewData.
(-[WKView _shouldIgnoreWheelEvents]):
Implement the old -shouldIgnoreMouseEvents behavior.
(-[WKView scrollWheel:]):
-shouldIgnoreMouseEvents -> -_shouldIgnoreWheelEvents.

* UIProcess/mac/WKActionMenuController.mm:
(-[WKPagePreviewViewController loadView]):
Configure the WKWebView to ignore non-wheel mouse events; use RetainPtr for the WKWebView.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Shapes] shape-image-threshold parsing tests have a few failures
https://bugs.webkit.org/show_bug.cgi?id=138060

Reviewed by Dirk Schulze.

Remove testing for inline style from the CSSWG test because it isn't
specified and isn't consistent across browsers. This has been updated
upstream as well.

Add inline style tests to the WebKit test suite to make sure that
WebKIt doesn't lose coverage with this change.

* TestExpectations:
* css3/shapes/shape-outside/values/shape-image-threshold-001-expected.txt:
* css3/shapes/shape-outside/values/shape-image-threshold-001.html:
* fast/shapes/parsing/parsing-shape-image-threshold-expected.txt:
* fast/shapes/parsing/parsing-shape-image-threshold.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Action menu URL preview should "peek," i.e. appear when the menu item is 
highlighted
https://bugs.webkit.org/show_bug.cgi?id=138432
-and corresponding-
rdar://problem/18774264

Reviewed by Anders Carlsson.

New ivars. Keep a reference to the popover, and a BOOL that indicates whether we 
should close the popover when the menu goes away.
* UIProcess/mac/WKActionMenuController.h:
* UIProcess/mac/WKActionMenuController.mm:

Re-set the preview bool to NO whenever we are about to pop up a new menu.
(-[WKActionMenuController prepareForMenu:withEvent:]):

Close the popover when the menu closes unless _shouldKeepPreviewPopoverOpen has 
been set.
(-[WKActionMenuController didCloseMenu:withEvent:]):

Set _shouldKeepPreviewPopoverOpen.
(-[WKActionMenuController _keepPreviewOpen:]):

Re-factored to use ivar.
(-[WKActionMenuController _previewURLFromActionMenu:]):
(-[WKActionMenuController _createPreviewPopoverForURL:]):

Now call _previewURLFromActionMenu on menu item highlight.
(-[WKActionMenuController menu:willHighlightItem:]):

NSPopover delegate method so that we can keep our BOOL and ivar accurate in the 
case where the popover is closed by some other mechanism than the action menu 
going away.
(-[WKActionMenuController popoverWillClose:]):

New selector for the preview. Now when this item is actually selected, we just 
want to set the BOOL _shouldKeepPreviewPopoverOpen to YES so that we keep the 
preview open.
(-[WKActionMenuController _createActionMenuItemForTag:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Shapes] Positioned polygon reftests failing again
https://bugs.webkit.org/show_bug.cgi?id=138058

Reviewed by Anders Carlsson.

Remove these tests from TestExpectations since they do pass.

* TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Disable action menus on page previews
https://bugs.webkit.org/show_bug.cgi?id=138431

Patch by Conrad Shultz <conrad_shultz@apple.com> on 2014-11-05
Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _shouldIgnoreMouseEvents]):
Renamed from -shouldIgnoreMouseEvents since this isn't actually public.
(-[WKView swipeWithEvent:]):
(-[WKView mouseMoved:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
Updated to reflect method rename.
(-[WKView shouldIgnoreMouseEvents]): Deleted.

* UIProcess/API/mac/WKViewInternal.h:
Expose -_shouldIgnoreMouseEvents.

* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
Cancel the menu if the presenting WKView should ignore mouse events.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebContent crash in WebPage::selectWithGesture()

<https://bugs.webkit.org/show_bug.cgi?id=138399>
<rdar://problem/18550631>

This crash occurs when the web process receives a "TapAndAHalf" gesture
with the "Changed" state without having received a "TapAndAHalf"
gesture with the "Began" state.

No test possible.

Reviewed by Simon Fraser.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
Null check m_currentWordRange before dereferencing it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@175636 268f45cc-cd09-0410-ab3c-d52691b4dbfc