LogEvent(string, map) and requested unit test

@dkorolev PTAL
I'm cool with this, just pointing out. :-)

Thanks,
Dima

http://dimakorolev.com/ | http://www.linkedin.com/in/dimakorolev |
dmitry.korolev@gmail.com | +1 (312) 593 2783


On Sun, Dec 14, 2014 at 4:06 PM, Alex Zolotarev <notifications@github.com>
wrote:
>
> In src/logger.h
> <https://github.com/KnowSheet/Alohalytics/pull/1#discussion-diff-21802686>
> :
>
> >  #endif
> >
> > +// Pretty-printing for std::pair.
> > +template <typename T, typename U>
> > +std::ostream& operator<<(std::ostream& out, const std::pair<T, U>& p) {
> > +  out << "[" << p.first << "=" << p.second << "]";
> > +  return out;
> > +}
> > +
> >  namespace aloha {
> >
> >  class Logger {
> >    std::ostringstream out_;
>
> But code is much easier to read when you see all member variables first
> before methods which are using it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/KnowSheet/Alohalytics/pull/1/files#r21802686>.
>