editing attribute