klocwork, help file changes and segfault issue resolved in job launch code.

Following are the changes in this branch

1) klocwork reported issues in job launch code (orun.c, orcmsd.c, sst_orcmsd.c)
2) Changes related to help file lookup for orcmsd tool
3) Fixing a segfault issue  with the mca destructor for the newly added mca parameter in the sst_orcmsd_components file (orcm_node_regex, orcm_base_jobid, orcm_base_vpid).
We probably should continue to conform to the MCA param naming conventions.
What I would suggest is to add a cmd line option to the orcmsd so you can
pass this easier. For example, we usually would do it by adding a block to
the cmd line definition array:

    { "sst_orcmsd_node_regex, '\0', "node-regex", "node-regex", 0,
      NULL, OPAL_CMD_LINE_TYPE_STRING,
      "Regular expression defining the nodes in this session" },

You would then just add this to the argv for the orcmsd cmd:

opal_argv_append_nosize(&argv, "--node-regex");
opal_argv_append_nosize(&argv, regex);

Make sense?
Ralph




On Tue, Jun 24, 2014 at 8:48 PM, lrrajesh <notifications@github.com> wrote:

> In orcm/mca/sst/orcmsd/sst_orcmsd_component.c:
>
> >                                 &mca_sst_orcmsd_component.node_regex);
> > +    (void) mca_base_var_register_synonym(var_id, "orcm", "orcm", NULL,
>
> Synonym gives me a short form of Mac name. It is easy to remember with
> short name. If you don't like I will remove this.
> Sent from my iPhones On Jun 24, 2014, at 6:26 PM, "rhc54" <
> notifications@github.com<mailto:notifications@github.com>> wrote: In
> orcm/mca/sst/orcmsd/sst_orcmsd_component.c:
>  &mca_sst_orcmsd_component.node_regex); + (void)
> mca_base_var_register_synonym(var_id, "orcm", "orcm", NULL,
> Is there some reason to create these synonyms? I see nothing wrong with
> leaving the param as "sst_orcmsd_node_regex". It would be more accurate and
> in keeping with the normal MCA param convention. We only use synonyms for
> backward compatibility, and that isn't the case here. — Reply to this email
> directly or view it on GitHub<
> https://github.com/open-mpi/orcm/pull/7/files#r14165356>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/open-mpi/orcm/pull/7/files#r14165758>.
>