Maint: Be more clear that puppet queue is deprecated

- Remove link to old wiki docs
- Link to PuppetDB docs
- Say "deprecated" again
Maint: (#18294) Update docs for ip property of Zone type (allows defrouters since 2.6)

Per Redmine 18294, the Zone type has allowed specifying default routers as part
of the IP string since at least 2.6 -- see Redmine 4296 for deets. This commit
updates the doc string to show how to do that.
Maint: Move pkgdmg documentation into provider description; document changed behavior

This wiki page was more longwinded than it needed to be; you can really sum it
up in about four bullet points. So I did that, and removed the wiki link.

Also, while investigating what the wiki said, it became clear that this provider
no longer actually uses open-uri: a Kernel.open call was changed to File.open,
but apparently nobody was using file:/// URLs (or anything weirder), so it went
unnoticed. So I added some comments for future maintainers of this code.
Maint: Remove remaining links to wiki pages in Puppet source

These pages now all have better-maintained counterparts in the main docs site.
(#16570) Don't load the node object again in configurer

Avoid loading the node object again if we already have a catalog.
(PUP-798) Add call to watch_files to ensure reparsing

This adds a call to watch_file in the code path for the future
parser/evaluator at the same place such call is made in the 3x
implementation. 

The ParserFactory is given an environment, and when this is 
a real environment, its known_resource_types are given to the parser
adapter being created to allow it to make the call to watch_file.
Bug 1051 (platforms mistook for versions)

Fix bug PUP-1051 by stripping out the extraneous platform info from the individual versions of the gems.
(Maint) Remove duplicate test

There are other tests that use the module tool to search for modules.
This kind of check is better done in one of those where the system just
"has to work" as part of some larger narrative arc.
(PUP-672) Add acceptance test for trusted data

This adds a check that the certificate extensions show up as trusted
data. Does not yet pass as the feature isn't implemented yet.
Merge remote-tracking branch 'hlindberg/pup-798_watch-files-must-be-called' into maint/master/test-future-prs

* hlindberg/pup-798_watch-files-must-be-called:
  (PUP-798) Add call to watch_files to ensure reparsing
(Maint) Remove use of mocking

Using the mocks is not absolutely necessary in this case. It is easy to
construct the certificate and using it makes it a little clearer what
kind of object we are dealing with.
(PUP-672) Add nested context capabilities

A major problem in puppet is keeping track of contextual information.
The Puppet::Indirector::Request attempts to do this, but it isn't able
to pass that information between indirector requests. This adds a
global context system, where once a value is set it cannot be changed,
but a subcontext can be created.
(maint) Log exception using log_exception

The master application was not using Puppet.log_exception to log out any
errors that might occur during --compile. This meant that there was no
backtrace information available to diagnose the problem.
(PUP-672) Add defaults for context lookups

Before it wasn't possible to get a value from the context that might not
have the requested binding. This adds the ability to provide a default
in the case where there is no finding for the name.
(PUP-672) Track trusted information using the context

This pulls apart the indirector request and the trusted information. The
trusted information is stored in the Puppet::Context and overridden by
the remote request handler to allow the injection of various elements of
trusted information. The reason to separate it from the indirector
request is because the indirector requests are hard to control, as they
are contstructed from hashes of information passed around and
manipulated. This should provide a more straightforward mechanism for
managing this kind of "contextual" information.
(PUP-798) E4ParserAdapter watches files through Environment

Instead of passing known_resource_types, if present, pass the given
environment, and provide a delegate method to watch_file on Environment.
Clears up a few layers of type checking and does not require the adapter
to know anything about known_resource_types for the purpose of watching
files, but a valid environment must be passed.
(maint) Uniform use of TypeCollectionHelper in Scope

Scope includes TypeCollectionHelper which provides an accessor for
known_resource_types.  This patch just fixes a direct reference to
environment.known_resource_types to instead use the delegate method the
same as other known_resource_types calls in the Scope class.
(PUP-672) Provide certificate extensions as trusted data

This extends the trusted information that is exposed to the system and
manifests to include the certificate extensions that are part of the
certificate provided by the agent. Only the custom extensions that are
part of the puppet extension arc are included.
(PUP-672) Updated test to match trusted data structure

During implementation of the trusted extensions the layout of the
trusted hash changed a little bit. This updates the acceptance test to
reflect that and also changes it to be much more straightforward to
read for the expected structure.
(maint) cron: Make the munge method for the command property more readable

The removal of leading and trailing spaces in cron commands was
performed using a perlism instead of just using String#strip.
Do that instead.