packet-hislip.c: Fix various bugs and deficiencies

- Remove an incorrect call to conversation_new()
  (which messed up TCP sequence number analysis).
- hislip Request/Response analysis must be done during 'pass1'
  (i.e. when 'flags.visited == 0');
  Not doing so caused various problems including
   tshark '1 pass' poor dissection.
- Remove 'if (tree)' around a call to expert_...().
- Don't show "unknown" for Async/Sync when the value is actually known.
- Simplify some code.
- Mark a field as GENERATED.

Change-Id: I286c12f52e5f73377bed3a2792f3ff0003e2785f
Reviewed-on: https://code.wireshark.org/review/3541
Petri-Dish: Bill Meier <wmeier@newsguy.com>
Reviewed-by: Bill Meier <wmeier@newsguy.com>
packet-hislip.c: various minor fixes

- Create/use an extended value-string;
- Clean up code relating to setting COL_PROTO & COL_INFO;
- Use consistent whitespace formatting.

Change-Id: I3087d959db09cd90c1a5dd53fe7af7baf999b76c
Reviewed-on: https://code.wireshark.org/review/3542
Reviewed-by: Bill Meier <wmeier@newsguy.com>
IAPP: Remove an unused variable.

Change-Id: Iee584bdb384056afe0f980bf18163b449ccecf59
Reviewed-on: https://code.wireshark.org/review/3544
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Fix the CMake QT build

The HAVE_PCAP_REMOTE definition is in config.h, so the .h files
that depend on the definition must include it so the MOC compiler
will generate the required code.

Change-Id: Ifc17db4fc3f0e3323726792308e303d28d8bcc7f
Reviewed-on: https://code.wireshark.org/review/3516
Reviewed-by: Evan Huus <eapache@gmail.com>
Minor typo corrections

Change-Id: I5962ba6a9b9285095ddacf00307a3094c697461a
Reviewed-on: https://code.wireshark.org/review/3546
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Give more information about string encodings.

Fix some indentation while we're at it.

Change-Id: I887af6e7507e1cd3c7e2b5bb5124d913aea01f9c
Reviewed-on: https://code.wireshark.org/review/3552
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Fix modeline (use Wireshark standard with C comment and no C++ comment)

Fix also some indent (tab->4spaces)

Change-Id: Ieef26591d405c6abe622f9fa26d2a7117af3c259
Reviewed-on: https://code.wireshark.org/review/3548
Reviewed-by: Anders Broman <a.broman58@gmail.com>
SNMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: Ifd4fef4ff7cc5a3197a802e0da5851370ddcd715
Reviewed-on: https://code.wireshark.org/review/3549
Reviewed-by: Evan Huus <eapache@gmail.com>
SNMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I00d66ff57fd3ea1ede692c85b2ae0286c30557b7
Reviewed-on: https://code.wireshark.org/review/3550
Reviewed-by: Evan Huus <eapache@gmail.com>
SNMP: fix mixed indent (use tab)

Change-Id: I19fde26bf7d1d2b19fcb56573f6e0814d1a7b8ab
Reviewed-on: https://code.wireshark.org/review/3551
Reviewed-by: Evan Huus <eapache@gmail.com>
Guard against buffer overflow when copying group key bytes into
security association structure.

Change-Id: I2f573a0626bab44aaca1ac6716bf5ac3d6a9b7ed
Reviewed-on: https://code.wireshark.org/review/3553
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Use an explicit path for stats_tree_dialog.cpp.

Change the entry for stats_tree_dialog.cpp in ui/qt/QtShark.pro to
have a relative "../qt/" path, so that Qt Creator can find it from its
build...-release temporary directory.

Change-Id: I8fa40e15a7fbb643d5565e216ce92f73afcd4871
Reviewed-on: https://code.wireshark.org/review/2340
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Fix generation of wslua taps in out-of-source-tree builds when the source tree
is a source tarball (rather than git):

Don't put the $(srcdir) path (from when the source tarball was made) into the
C file: that file isn't regenerated when ./configure is run.  (This is a
correction to 0996730b91fddbf8aa7c61730a50da28ea1ab6a0).

Also change a few dependency paths so they'll work in out-of-source-tree builds.

Change-Id: I416f2d3611fb61659b9a7f7285e5f54a354fbe7d
Reviewed-on: https://code.wireshark.org/review/3554
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Remove a bogus make-dissector-reg dependency from UseMakeDissectorReg.cmake

The shell script is not used in the CMake build system.

Change-Id: I97d3d750f2521c626594200da8fc9a4453414576
Reviewed-on: https://code.wireshark.org/review/3530
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
NSIS: check Windows version before running uninstaller

Change-Id: Icc8d725bff484c48d14e0a9208c545ca512a9768
Reviewed-on: https://code.wireshark.org/review/3533
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
Petri-Dish: Christopher Maynard <Christopher.Maynard@gtech.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Remove parsing of non-existing TS_UD_SC_SEC1 fields

When RDP encryption method/level is NONE (CredSSP implies this case), TS_UD_SC_SEC1::encryptionLevel is the last present field. Subsequent fields aren't present in this case.

Change-Id: I44cfea3ed52fae1ed6c416aeb01c3cf6ff002a3c
Reviewed-on: https://code.wireshark.org/review/3545
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Remove unneeded include of config.h

Change-Id: I7688c9a9dc88023d562fb665109185e22f2d06e8
Reviewed-on: https://code.wireshark.org/review/3560
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
When checking if a message is Diameter also check for a minimum message length.

This improves the detection of Diameter messages within a TCP bytestream (i.e.,
when the Diameter PDUs don't neatly align with frames).

Bug: 10362
Change-Id: I49a6e8cf076a6ab8a14761493aab9f3b11e4756e
Reviewed-on: https://code.wireshark.org/review/3557
Petri-Dish: Evan Huus <eapache@gmail.com>
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Remove make-dissector-reg and require python for autotool builds as well

Change-Id: I6239063a08ba37199a4e95302a3650a80544c750
Reviewed-on: https://code.wireshark.org/review/3562
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Indicate that Python is required to compile Wireshark.

Remove some trailing white space at the same time.

(The ./configure options in INSTALL are significantly out of date--that will
be the subject of a separate commit.)

Change-Id: I3c03f90dab099e6d3386a235f35b691e7ff671be
Reviewed-on: https://code.wireshark.org/review/3563
Reviewed-by: Daniel Black <danielblack@fedoraproject.org>
Reviewed-by: Evan Huus <eapache@gmail.com>