ok.  move the comment to the top of the file.


On Thu, Mar 20, 2014 at 5:33 PM, Sarina Canelake
<notifications@github.com>wrote:

> In common/lib/xmodule/xmodule/tabs.py:
>
> > +        Python dictionary objects.  For example: course_tab['name'] = new_name
> > +
> > +        Note: the 'type' member can be 'get', but not 'set'.
> > +        """
> > +        if key == 'name':
> > +            self.name = value
> > +        elif key == 'tab_id':
> > +            self.tab_id = value
> > +        else:
> > +            raise KeyError('Key {0} cannot be set in tab {1}'.format(key, self.to_json()))
> > +
> > +    # pylint: disable=incomplete-protocol
> > +    # Note: pylint complains that we do not implement __delitem__ and __len__, although we implement __setitem__
> > +    # and __getitem__.  However, the former two do not apply to this class so we do not implement them.  The
> > +    # reason we implement the latter two is to enable callers to continue to use the CourseTab object with dict-type
> > +    # accessors.
>
> You disable this both here and at the top of the file. Disable it in one
> place and put the explanation of why you're disabling it in that one place.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/2910/files#r10817595>
> .
>



-- 

edX | nasthagiri@edx.org <andya@edx.org>

141 Portland Street, 9th floor

Cambridge, MA 02139
http://www.edx.org <http://www.edxonline.org/>

[image:
http://www.e-learn.nl/media/blogs/e-learn/edX_Logo_Col_RGB_FINAL.jpg?mtime=1336074566]