isl_input.c: accept_extended_affine: plug memory leak on error path

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
isl_printer_free: free indent_prefix

We missed this in 023740f (isl_printer: add indent_prefix,
Sat Feb 8 14:31:30 2014 +0100).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
remove WARN_UNUSED from public header

WARN_UNUSED is only meant to be used internally (it does not even
start with ISL_) and should therefore not appear in a public header.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
isl_sample.c: tab_shift_cone: use isl_tab_extend_cons instead of isl_tab_extend

Since an isl_tab is not reference counted, there is no way for
tab_shift_cone to tell its callers that the isl_tab has already
been freed, possible resulting in double frees on errors
in isl_tab_detect_equalities.  tab_shift_cone calls isl_tab_extend
which is just a wrapper around isl_tab_extend_cons turning
the appropriate interface of returning -1 on error into a bad interface
of freeing the isl_tab and returning NULL.  Call isl_tab_extend_cons
directly instead.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
Merge branch 'maint'
drop isl_tab_extend in favor of isl_tab_extend_cons

Since an isl_tab is not reference counted, there may be no way for
callers of isl_tab_extend their callers that the isl_tab has already
been freed, possible resulting in double frees on errors.
isl_tab_extend is just a wrapper around isl_tab_extend_cons turning
the appropriate interface of returning -1 on error into a bad interface
of freeing the isl_tab and returning NULL.
Move the single remaining call to isl_tab_extend to a call
to isl_tab_extend_cons.  This does not solve any problems in itself
but should avoid future problems with isl_tab_extend.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
Avoid uninitialized memory warning in valgrind when compiled with gcc-4.7

We initialize a variable with zero to avoid valgrind warnings about
uninitialized memory when isl is compiled with gcc-4.7. The memory is
never used uninitialized and neither clang nor gcc-4.6 compiled code
shows these warnings. We initialize it anyway to reduce the valgrind
noise.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>