+1


On Fri, Jan 24, 2014 at 1:03 PM, Jai Ram Rideout
<notifications@github.com>wrote:

> In bipy/core/sequence.py:
>
> > +             newline in the string, you can pass terminal_character="")
> > +        """
> > +        if self._identifier != "" and self._description != "":
> > +            header_line = "%s%s%s" % (
> > +                self._identifier, field_delimiter, self._description)
> > +        elif self._identifier == "" and self._description == "":
> > +            header_line = ""
> > +        elif self._identifier:
> > +            header_line = self._identifier
> > +        elif self._description:
> > +            header_line = "%s%s" % (field_delimiter, self._description)
> > +        else:
> > +            # we've exhausted the possibilities - it shouldn't be
> > +            # possible to get here, but just in case...
> > +            raise BiologicalSequenceError(
> > +                "Can't construct header line in BiologicalSequence.toFasta.")
>
> Since you're raising an exception that has a stack trace, putting the
> class and method name in the error message seems a bit redundant and likely
> to get out of sync
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/biocore/bipy/pull/53/files#r9161095>
> .
>