state, etc: state.Info.Tag is now a names.Tag not a string

This change redefines state.Info.Tag as a names.Tag. 

This uncovered a lot of nastiness in the tests where an invalid tag was being used as a test fixture and then the incorrect result was asserted. An example of this is the agent.ConfigFile stuff which we all know _should_ write a file like fmt.Sprintf("%s-%s", tag.Kind(), tag.Id()), but the test fixtures were wrong.
I'm not raising bugs for these. Have you seen how many there are in this PR
?


On Wed, Jul 9, 2014 at 2:25 PM, waigani <notifications@github.com> wrote:

> In cmd/jujud/agent_test.go:
>
> > @@ -397,7 +398,10 @@ func (e *errorAPIOpener) OpenAPI(_ api.DialOpts) (*api.State, string, error) {
> >  }
> >
> >  func (s *agentSuite) assertCanOpenState(c *gc.C, tag, dataDir string) {
> > -	config, err := agent.ReadConfig(agent.ConfigPath(dataDir, tag))
> > +	// TODO(dfc) tag should be a Tag not a string
>
> bug number?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/juju/juju/pull/267/files#r14693108>.
>