yup.  done.  thanks.


On Thu, Mar 20, 2014 at 11:13 AM, David Baumgold
<notifications@github.com>wrote:

> In common/lib/xmodule/xmodule/tabs.py:
>
> > +            TextbookTabs.type,
> > +            PDFTextbookTabs.type,
> > +            HtmlTextbookTabs.type,
> > +        ]:
> > +            cls._validate_num_tabs_of_type(tabs, tab_type, 1)
> > +
> > +    @staticmethod
> > +    def _validate_num_tabs_of_type(tabs, tab_type, max_num):
> > +        """
> > +        Check that the number of times that the given 'tab_type' appears in 'tabs' is less than or equal to 'max_num'.
> > +        """
> > +        count = sum(1 for tab in tabs if tab.get('type') == tab_type)
> > +        if count > max_num:
> > +            raise InvalidTabsException(
> > +                "Tab of type '{0}' appears {1} time(s). Expected maximum of {2} time(s).".format(
> > +                tab_type, count, max_num))
>
> Nitpick: can you adjust your indentation here, and bring the ) down to
> the next line, so this is easier to read?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/2910/files#r10798933>
> .
>



-- 

edX | nasthagiri@edx.org <andya@edx.org>

141 Portland Street, 9th floor

Cambridge, MA 02139
http://www.edx.org <http://www.edxonline.org/>

[image:
http://www.e-learn.nl/media/blogs/e-learn/edX_Logo_Col_RGB_FINAL.jpg?mtime=1336074566]