Sz dsc 287

Hi Shaun,

This request contains updates for represent work function, could you please review these changes?

Thanks,
Shuang
All good suggestions – making the suggested changes now.

Thanks

shaun

From: shuangzhou <notifications@github.com<mailto:notifications@github.com>>
Reply-To: nla/amberdb <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, 17 November 2014 7:56 PM
To: nla/amberdb <amberdb@noreply.github.com<mailto:amberdb@noreply.github.com>>
Cc: Shaun Coen <scoen@nla.gov.au<mailto:scoen@nla.gov.au>>
Subject: Re: [amberdb] Sz dsc 287 (#241)


In src/amberdb/AmberSession.java:

> +                    representedBy.put(rep.getId(), copy.getId());
> +                }
> +            }
> +
> +            /* process the descendant works */
> +            depth++;
> +            getWorksRepresentedByCopiesOf(representedBy, depth, Iterables.toArray(work.getChildren(), Work.class));
> +        }
> +
> +        return representedBy;
> +    }
> +    public Map<Long, Long> getWorksRepresentedByCopiesOf(final Work... works) {
> +        return getWorksRepresentedByCopiesOf(new HashMap<Long, Long>(), 0, works);
> +    }
> +
> +


Looks good otherwise.

—
Reply to this email directly or view it on GitHub<https://github.com/nla/amberdb/pull/241/files#r20423064>.