Container#AllocateNetwork: Simplify error handling.

The defer logic was a little tricky and was hiding one bug: `err` was
being redefined (with `:=`) and thus it escaped the defer error checking
logic.

Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
Add test for ignoring invalid dockerfile instructions

Signed-off-by: Tibor Vass <teabee89@gmail.com>
ignore invalid Dockerfile instructions and do not consider "docker-version" a Dockerfile instruction

Signed-off-by: Tibor Vass <teabee89@gmail.com>
back from camping, and making fred the docs 'guy in charge'

Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@docker.com> (github: SvenDowideit)
Increase the tag length limit from 30 to 128

Signed-off-by: Burke Libbey <burke.libbey@shopify.com>
Fix system socket/service unit files

Two problems how they are today:

In the current systemd unit files it is impossible to have the
docker.service started at system boot.  Instead enableing docker.service
will actually enable docker.socket.  This is a problem, as that means
any container with --restart=always will not launch on reboot.  And of
course as soon as you log in and type docker ps, docker.service will be
launched and now your images are running.  Talk about a PITA to debug!
The fix is to just install docker.service when people ask docker.service
to be enabled.  If an admin wants to enable docker.socket instead, that
is fine and will work just as it does today.

The second problem is a common docker devel workflow, although not
something normal admins would hit.  In this case consider a dev doing
the following:

systemctl stop docker.service

docker -d
[run commands]
[^C]

systemctl start docker.service

Running docker -d (without -F fd://) will clean up the
/var/run/docker.sock when it exits.  Remember, you just ran the docker
daemon not telling it about socket actviation, so cleaning up its socket
makes sense!  The new docker, started by systemd will expect socket
activation, but the last one cleaned up the docker.sock.  So things are
just broken.  You can, today, work around this by restarting
docker.socket.  This fixes it by telling docker.socket that it is
PartOf=docker.service.  So when docker.service is
started/stopped/restarted docker.socket will also be
started/stopped/restarted.  So the above semi-common devel workflow will
be fine.  When docker.service is stopped, so is docker.socket,   docker
-d (without -F fd://) will create and delete /var/run/docker.sock.
Starting docker.service again will restart docker.socket, which will
create the file an all is happy in the word.

Signed-off-by: Eric Paris <eparis@redhat.com>
Merge pull request #8434 from tiborvass/ignore_invalid_Dockerfile_instructions

Ignore unknown dockerfile instructions
Allow child to overwrite entrypoint from parent

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Merge pull request #8451 from eparis/systemd

Fix system socket/service unit files
Merge pull request #8459 from crosbymichael/entrypoint-parent

Allow child to overwrite entrypoint from parent
Merge pull request #8437 from SvenDowideit/un-pto-sven-oct-2014

back from camping, and making fred the docs 'guy in charge'
Merge pull request #8431 from aluzzardi/b-alloc-network-error-handling

Container#AllocateNetwork: Simplify error handling.
Merge pull request #8447 from burke/bump-tag-char-limit

Increase the tag length limit from 30 to 128
Deprecating ResolveRepositoryName

Passing RepositoryInfo to ResolveAuthConfig, pullRepository, and pushRepository

Moving --registry-mirror configuration to registry config

Created resolve_repository job

Repo names with 'index.docker.io' or 'docker.io' are now synonymous with omitting an index name.

Adding test for RepositoryInfo

Adding tests for opts.StringSetOpts and registry.ValidateMirror

Signed-off-by: Don Kjer <don.kjer@gmail.com>
gofmt changes

Signed-off-by: Don Kjer <don.kjer@gmail.com>
Fixing search term use of repoInfo

Signed-off-by: Don Kjer <don.kjer@gmail.com>
First pass at adding --force-fully-qualified

Partial cleanup of job policy flags and configuration.  Created resolve_repository job

More cleanup of registry policies

Deprecating ResolveRepositoryName in favor of ResolveRepositoryInfo

Passing RepositoryInfo to ResolveAuthConfig, pullRepository, and pushRepository

Renaming registry/policy.go to registry/config.go.  Moving --registry-mirror configuration to registry config

Adding Server: prompt to login

Querying daemon for fqn command restrictions on login

Fixing issues with RepositoryInfo.Resolve()

Renaming official index: index.docker.io => docker.io

Removing 'Hostname' from RepositoryInfo
Adding test for ValidateFullyQualifiedCmd