Honestly, I don't know think Python uses the "on" convention. If I did rename it, I would rename it to "on_editor_save" as we want to be clear who did the save (the xblock can save itself).

It think I'm just going to leave it as-is.