add always flag to custom properties

Actually, ideally, the custom won't run unless one of the group's params
have changed (no need to ifdown/ifup, e.g., if nothing changed
network-wise), so I think current behavior is OK


On Mon, Jun 16, 2014 at 8:40 AM, james-crocker <notifications@github.com>
wrote:

> In src/lib/perl/OVF/Custom/Module.pm:
>
> > @@ -64,7 +65,7 @@ sub apply ( $$\% ) {
> >
> >  		if ( $customPriority eq $priority ) {
> >
> > -			if ( !exists $options{ovf}{previous} ) {
> > +			if ( !exists $options{ovf}{previous} || $always) {
>
> Is the intent that an 'always' custom item should fire on each system
> boot, regardless of whether the property changed or not? If so, the line 50
> above if ( !OVF::State::ovfIsChanged( $property, %options ) ) { ... return
> ... } will skip the custom 'always' defined property. Unless some property
> was changed in the property 'group' the always custom part won't run.
> (Either way I will also add back the Custom::Module::apply back into the
> fvorge-lite.pl)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/siostech/fvorge/pull/6/files#r13802770>.
>