Merge contants-doc-typo-6525: Fix typo in constants documentation.

Author: Alex
Reviewers: tom.prince
Fixes: #6525

The `hasBody` example was backwards, it should be `not in`.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38460 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Static static static


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38483 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge dist-trial-path-6390

Author: therve
Reviewers: glyph, tom.prince
Fixes: #6390

Remove the preamble setting the sys.path for trial dist children, and pass an
environment variable instead.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38491 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge knownhostsfile-savepath-6255

Author: racheesingh
Reviewer: Julian, exarkun
Fixes: #6255

Give `twisted.conch.client.knownhosts.KnownHostsFile` a public `savePath` attribute
which identifies the filesystem path to which information is saved and from which
it is loaded.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38494 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge circular-deferred-6164

Author: radix
Reviewer: therve
Fixes: #6164

If a callback that is attached to a Deferred returns that same Deferred,
a warning will now be emitted. Deferred howto documentation has been updated.



git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38513 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge string-transport-disconnection-failure-6521

Author: adiroiban
Reviewer: therve
Fixes: #6521

Pass a Failure instead of a plain exception in
StringTransportWithDisconnection.loseConnection.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38517 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge sslverify-no-pickle-6166: Deprecate pickling support in twisted.internet._sslverfiy.

Authore: canibanoglu
Reviewers: tom.prince
Fixes: #6166

Pickleability is no longer a goal for Twisted. As such, the
various __getstate__ and __setstate__ methods of
twisted.internet._sslverify classes can be deprecated, so we
can remove the extra code involved.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38519 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Revert r38517 - test suite regression

Reopens: #6166

A number of test modules now fail to import on some builders:

{{{
[ERROR]
Traceback (most recent call last):
  File "/data/home/buildbot/work/freebsd-8.2-i386/Twisted/twisted/trial/runner.py", line 500, in loadPackage
    module = modinfo.load()
  File "/data/home/buildbot/work/freebsd-8.2-i386/Twisted/twisted/python/modules.py", line 383, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/data/home/buildbot/work/freebsd-8.2-i386/Twisted/twisted/python/_reflectpy3.py", line 266, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/data/home/buildbot/work/freebsd-8.2-i386/Twisted/twisted/python/_reflectpy3.py", line 205, in _importAndCheckStack
    return __import__(importName)
  File "/data/home/buildbot/work/freebsd-8.2-i386/Twisted/twisted/test/test_sslverify.py", line 805, in <module>
    class KeyPair(unittest.TestCase):
  File "/data/home/buildbot/work/freebsd-8.2-i386/Twisted/twisted/test/test_sslverify.py", line 808, in KeyPair
    CN=b"server")[0]
  File "/data/home/buildbot/work/freebsd-8.2-i386/Twisted/twisted/test/test_sslverify.py", line 84, in makeCertificate
    keypair = PKey()
exceptions.NameError: global name 'PKey' is not defined

twisted.test.test_sslverify
}}}



git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38527 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Raiders of the twisted ark


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38543 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge only-child-setuid-6443

Author: exarkun
Reviewer: tom.prince
Fixes: #6443

Avoid changing the process UID or GID when launching a child process which is to
run with a different UID or GID.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38550 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Revert r38550 - test suite regression

New tests fail on Windows, which lacks UIDs and GIDs.

Reopens: #6443


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38552 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge only-child-setuid-6443

Author: exarkun
Reviewer: tom.prince
Fixes: #6443

Avoid changing the process UID or GID when launching a child process which is to
run with a different UID or GID.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38568 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
TestDeprecationWarnings.test_deprecatedUpdatesDocstring now uses a locally
defined function for testing, fixing a conflict with other tests in the module
which was breaking trial --until-failure.

Author: canibanoglu
Reviewer: therve
Fixes: #5197


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38572 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge http-getBody-6251-2

Author: tom.prince, exarkun
Reviewer: therve
Fixes: #6251

Introduce a Twisted Web client helper, `twisted.web.client.readBody`, for
extracting the body of an HTTP response all at once.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38574 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge branches/kept-errors-6510

Author: wsanchez
Reviewer: therve
Fixes: #6510

Remove no-longer used keepErrors implementation bits in twisted.python.log.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38577 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Remove a unused variable in sslverify KeyPair.signRequestObject method. 

Author: canibanoglu
Reviewer: therve
Fixes: #6498


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38578 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Remove deprecated API session related from twisted.web.server.

Author: canibanoglu
Reviewer: therve
Fixes: #6514


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38581 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge threadpool-contextmanager-5981-2

Authors: stephsolis, ephess
Reviewers: tom.prince, exarkun, therve
Fixes: #5981

Cleanup threadpool implementation by using context managers.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38584 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge webclient-request-cancel-4330-5

Author: habnabit, therve, itamar
Reviewer: itamar, exarkun
Fixes: #4330

Implement resource cleanup for cancellation of the Deferred returned by
`twisted.web.client.Agent.request`.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38599 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge standalone-setup3-6228-2

Author: therve
Reviewer: rwall
Fixes: #6228

Remove admin/_twistedpython3.py and put the list of ported modules in setup3.py
so that a source tarball can be installed with it.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@38607 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb