Bail early on null parameter

This convinces clang analyzer that there’s no
null dereference.

Change-Id: I2cc59ed9471bdad0137329c9d27e9492ea8581bd
Remove dead store to fix warning.

Looks like copy-paste.

Change-Id: I75810ebcd42c6c19110088b8411d71e65375b357
Added some consts in a few places

Change-Id: Ib7a96b7685e282456642c144cc7614197ae9093e
Put initial assignment at declaration

Change-Id: Id2c6b1f3497100b2b9b4509acc30dde5a1258869
Fixed analyzer warning by removing null check

The analyzer saw a check for null so assumed it could happen,
but it must be impossible, because there’s an unconditional
dereference just below.

Change-Id: Ibdb0bd6aee89ff1eadd8442d35b7d33f54486eb4
Fixed analyzer warning about possible null deref

Added check for null, other code above was doing it.

Change-Id: I0f58a1957d4586801b98805e0bd9bdcdf115eeb2
Fixed a few dead store warnings

Eliminated some dead stores, and also moved some
declarations & initial definitions together

Change-Id: Ic0bc1a1d1fc6fb6315bae8006584e4102ff51996
Fixed dead store warning by removing redundant 'break'

analyzer warned that setting 'nextPass' was never read afterwards,
which was true because there was a 'break' right after.  So just remove
the 'break' and allow the already-commented 'nextPass' logic to end the loop.
Changed 'nextPass' to bool also.

Change-Id: Iff85503f0235348a6c0d3ad9b0406cd96f1c4e35
Fixed dead store warning by reformulating loop

Switched while to do-while to fix warning about initial 'rayMag' setting
being dead.

Change-Id: I3944988ec87f9c9b51aa1b19a1ee3aaa2ad85b47
Fixed null dereference

Body of an ‘if’ set ‘ef = null’ then next ‘if’
unconditionally dereferenced it.

Change-Id: I1decc17579c5c9f7d3bfc5c5dc45ebb328573529
Fixed false positive warning about null deref

At the changed line, “graph” and “this->Graph”
should be the same, but the analyzer only sees
that the macro has branches for “graph” being null
or not, then sees it unconditionally dereferenced.

Change-Id: I80f12f4ae3bb31ddadbf72ad0bb522bfba015a20
Fixed null dereference

If the big for loop is never entered,
then slice1scalars would be null and dereferenced

Change-Id: I4c8300c0b082c9f1a8349659f83297f81efa9894
Fixed obvious null dereferences

Change-Id: Ia58a2fe42374dade0fb7005f2eb8d84c35401f29
Merge topic 'more-clang-analzyer' into master

57d3811f Fixed obvious null dereferences
ce0618c2 Fixed null dereference
1fa832c3 Fixed false positive warning about null deref
e2dad201 Fixed null dereference
c5917828 Fixed dead store warning by reformulating loop
8f0a469e Fixed dead store warning by removing redundant 'break'
832f091a Fixed a few dead store warnings
b8af0b7c Fixed analyzer warning about possible null deref
70d8784b Fixed analyzer warning by removing null check
93b12c9a Put initial assignment at declaration
ab36a82e Added some consts in a few places
a0c7098d Remove dead store to fix warning.
ca321864 Bail early on null parameter