fix params perhaps