set http.Client.Timeout in net2/http2.SimplePool if supported

pool.client.Timeout assumes the field is there at compile time.  it's
clearly not true in this case.



On Fri, Aug 22, 2014 at 4:52 PM, Harish Mallipeddi <notifications@github.com
> wrote:

> In net2/http2/simple_pool.go:
>
> > @@ -49,6 +71,10 @@ func NewSimplePool(addr string, params ConnectionParams) *SimplePool {
> >  		client: new(http.Client),
> >  	}
> >
> > +	if isClientTimeoutSupported(pool.client) {
> > +		pool.client.Timeout = params.ResponseTimeout
>
> Can you elaborate why this would break? isClientTimeoutSupported() is
> already doing reflection to determine if the http.Client struct has the
> Timeout field.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dropbox/godropbox/pull/69/files#r16626661>.
>