Merge pull request #13611 from robinboening/plugin_generator_tests

Add missing tests for invalid names in `rails plugin new` generator
Fix rdoc markup [ci skip]

Wrapping symbols with + does not work, we must use <tt> instead.
Fix typo [ci skip]
Fix AR connection resolver docs to return a hash with string keys [ci skip]
Fix typo in AS changelog, improve highlight [ci skip]
add example to the CHANGELOG entry from 3a48b83e5 [ci skip].

/cc @pixeltrix
Fix: ActiveRecord::Store TypeError conversion when using YAML coder

Renaming the test accordingly to its behaviour

Adding 'Fixes' statement to changelog

Improving tests legibility & changelog

Undoing mistakenly removed empty line & further improving changelog
Merge pull request #13593 from oliveiraethales/store_yaml_coder

Fix: ActiveRecord::Store TypeError conversion when using YAML coder
Remove warnings in test suite

lib/active_record/store.rb:79: warning: method redefined; discarding old color=
lib/active_record/store.rb:79: warning: previous definition of color= was here
lib/active_record/store.rb:83: warning: method redefined; discarding old color
lib/active_record/store.rb:83: warning: previous definition of color was here
Merge pull request #13616 from zirni/remove_warnings

Remove warnings in test suite
activerecord: Initialize Migration with version from MigrationProxy.
Add 'e' var on rescue DalliError, in order to log it
Merge pull request #13617 from arthurnn/error_var

Add 'e' var on rescue DalliError, in order to log it
Use a better method name to check the requirement of password confirmation

Also improve changelog entries related to secure password to proper
highlight.
Make change_table use object of current database adapter

  - Earlier, change_table was creating database-agnostic object.
  - After this change, it will create correct object based on current
    database adapter.
  - This will ensure that create_table and change_table will get same objects.
  - This makes update_table_definition method public and nodoc.
  - Fixes #13577 and #13503
Merge pull request #13597 from prathamesh-sonpatki/hstore_migration

Make change_table use object of current database adapter
Fix typo in image_tag documentation

image_tag only supports :alt and :size as additional keys, not three.
Merge pull request #13621 from Intrepidd/patch-1

Fix typo in image_tag documentation [ci skip]
Merge pull request #13355 from dylanahsmith/migration-version

activerecord: Initialize Migration with version from MigrationProxy.

Conflicts:
	activerecord/CHANGELOG.md
`core_ext/string/access.rb` test what we are documenting.

I also extracted the tests from a single bulk method into a separate test-case.
The new tests cover the API described in the docs.

There are two skipped tests, which are broken as of 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3
* #to with negative Fixnum, position is counted from the end
* #from and #to can be combined

This was brought to my attention by #13627.

Closes #13627.