What I was trying to do here is to improve the throughput in the case that
we are building linux and windows builds, but where the linux build
capacity is much higher than the windows build capacity.

If a gerrit review fails the linux build, we would like to remove the
corresponding queued windows job so as not to run builds that we know are
going to fail.


On Mon, Jan 27, 2014 at 4:23 PM, Robert Sandell <notifications@github.com>wrote:

> In
> gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java:
>
> > @@ -117,6 +117,10 @@ public synchronized void onCompleted(AbstractBuild r, TaskListener listener) {
> >                          logger.warn("InterruptedException while obtaining failure message for build: "
> >                                  + r.getDisplayName(), e);
> >                      }
> > +                    // Purge future jobs when one job fails. This improves throughput when
> > +                    // triggering multiple jobs where one job has lower throughput than
> > +                    // the others. The first failing job will purge other queued jobs.
> > +                    GerritTrigger.getTrigger(r.getProject()).notifyBuildEnded(event);
>
> I don't think this does what you intend.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jenkinsci/gerrit-trigger-plugin/pull/75/files#r9191624>
> .
>



-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
http://www.zylin.com/