Windows WML Tests: Add total duration to output
remove unnecessary argument to game_display::scroll_to_leader

The function was requiring a reference to unit map, although
the game_display owns a referece to this, and it was always
called with that instance.
game_display uses game_board in it's constructor
Don't catch config::error in config_cache::read_configs()

Reverts a bit of commit d6dfec6151fb6eb5dd2d9f2d96920f1a9d7ec1ca to fix
a regression affecting both master and 1.12 since after version 1.11.14
which was causing WML validity errors to not abort the WML load process
or result in a message to the user in the GUI.

The WML parser and preprocessor throw config::error and
preproc_config::error to signal callers of issues with user input (WML
documents, in this case).

We need any exceptions thrown by the WML parser or preprocessor to
propagate upstream so they can be caught by the code responsible for
initiating the sequence so it can best decide how to present them to the
user. For example, the game_config_manager class will format and pass
them to gui2::twml_error so that the user can be informed of errors in
an add-on or mainline through the GUI.

Because config_cache::read_configs() was catching the exception and not
propagating it upstream due to a change that's part of the
aforementioned commit, this sequence was broken, and while the error was
reported to stderr, the game continued as normal in most cases with
a malformed half-parsed WML tree, resulting in all kinds of misbehavior.

This issue was originally reported in the forums by SkyOne:
<http://r.wesnoth.org/p571380>
remove unused function
menu handler uses game_board in it's constructor
change a warning log message.
add variants of "find visible unit" to game_board

Allow size_t instead of reference to a team, also possibility to
query for presence of a visible unit instead of returning an
iterator to it.
Merge branch 'master' of git://github.com/wesnoth/wesnoth
Merge pull request #198 from aquileia/VC_update

Windows WML Tests: Add total duration to output
move some code out of play_controller to game_board
Merge branch 'master' of git://github.com/wesnoth/wesnoth
move extract_summary_from_config function
fixup "remove resources::state_of_game"

this was forgotten.
clean a dependency
use resources::classification/mp_setting instead of game_state

do_choose_level changing the value of mp_settings->mp_scenario is most
likeley a bug, because the value it was changed to wasn't related to the
finaly chosen level.
prevent msvc compiler warning
remove game_state from menu_handler
play_controllers uses const accessors to game_board

Favor these over using friend access to privates anyways.
Eventually will be able to factor that out.
Merge branch 'master' of git://github.com/wesnoth/wesnoth