WebPage::setComposition(), WebPageProxy::didFindStringMatches() should take Vector parameters by const reference
https://bugs.webkit.org/show_bug.cgi?id=133264

Reviewed by Darin Adler.

Taking the Vector parameters in the two methods (invoked through the IPC message handling)
by value causes unnecessary copies. The methods don't modify the objects and don't want
or need fresh copies, hence they should take in const references to Vector objects.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFindStringMatches):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setComposition):
* WebProcess/WebPage/WebPage.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove Vector copies in ShorthandPropertyWrapper implementation and use
https://bugs.webkit.org/show_bug.cgi?id=133265

Reviewed by Simon Fraser.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper): Move the passed-in Vector
into the member variable instead of using Vector<>::swap().
(WebCore::ShorthandPropertyWrapper::propertyWrappers): Return a const reference of the member
variable instead of a const value.
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Move the Vector
object into the ShorthandProperthyWrapper constructor.
(WebCore::gatherEnclosingShorthandProperties): Deploy a range-based for-loop.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Grid Layout] Children of grid containers must be turned into grid items
https://bugs.webkit.org/show_bug.cgi?id=132991

Reviewed by Darin Adler.

From Blink r150472 by <jchaffraix@chromium.org>

Source/WebCore:
According to specs each child of a grid container must become a
grid item meaning that grid items are grid level boxes and thus,
do not participate in the block formatting context but in the grid
formatting one.

This change updates the grid items' 'display' property after style
resolution so that we match the specification (see section 4. Grid
Items). The spec basically instructs us to compute the value of
'display' by applying the table in CSS2.1 Chapter 9.7
http://www.w3.org/TR/CSS2/visuren.html#dis-pos-flo

Test: fast/css-grid-layout/grid-item-display.html

* css/StyleResolver.cpp:
(WebCore::isDisplayGridBox):
(WebCore::StyleResolver::adjustRenderStyle):

LayoutTests:
Added a new test case to verify the computed value for 'display'
in grid items. The test also checks that items are correctly
positioned inside the grid, i.e., they properly became grid
items.

Also removed ietestcenter's grid-items-002.html and
grid-items-003.html from the list of failing tests as they should
be working now.

* fast/css-grid-layout/grid-item-display-expected.txt: Added.
* fast/css-grid-layout/grid-item-display.html: Added.
* ietestcenter/css3/grid/grid-items-002.htm: Fixed a typo and
replaced -webkit-grid-definition-* by -webkit-grid-template-*
* ietestcenter/css3/grid/grid-items-003.htm: Ditto.
* platform/efl/TestExpectations: Removed the two tests above.
* platform/gtk/TestExpectations: Ditto.
* platform/mac/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Input fields and text areas are not rendered correctly after r167771
https://bugs.webkit.org/show_bug.cgi?id=133181

Reviewed by Gyuyoung Kim.

Source/WebCore:
r167771 changed arguments of RenderTheme two virtual method arguments which were not reflected
in changes in derived classes, which caused parent method to be called. Arguments in derived class
were updated, also 'override' specifiers were added to all virtual methods to prevent similar errors.

Already covered by fast/forms/textarea-placeholder-wrapping.html

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintTextField):
(WebCore::RenderThemeEfl::paintTextArea):
* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::supportsHover):
(WebCore::RenderThemeEfl::supportsControlTints):

LayoutTests:
* platform/efl-wk2/TestExpectations: Remove now passing test from test expectations.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169335 268f45cc-cd09-0410-ab3c-d52691b4dbfc