I don't really like this commit at all. I thik we should just have
immutable druid servers.


On Sun, May 18, 2014 at 9:31 PM, Gian Merlino <notifications@github.com>wrote:

> In server/src/main/java/io/druid/server/coordinator/DruidCoordinator.java:
>
> > @@ -580,7 +600,7 @@ private void becomeLeader()
> >            );
> >          }
> >
> > -        final int startingLeaderCounter = leaderCounter;
> > +        startingLeaderCounter = leaderCounter;
>
> If a master starts runnables, then stops being leader, then starts being
> leader again (while the runnables are still running) this will not prevent
> the old, bad runnables from taking actions. The checks against
> startingLeaderCounter will see the new version of startingLeaderCounter and
> think they are okay.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/metamx/druid/pull/552/files#r12779134>
> .
>