Prefix name with defining package

Signed-off-by: mulhern <amulhern@redhat.com>
Suppress unpacking-non-sequence pylint warning

And be more explicit about the role of prev_prefix.

Signed-off-by: mulhern <amulhern@redhat.com>
Set child_factory_fstype to None in DeviceFactory

Otherwise, _get_child_factory_kwargs could raise an AttributeError in a
subclass where child_factory_fstype is undefined.

Signed-off-by: mulhern <amulhern@redhat.com>
Disable not-callable pylint warning.

The method will not reach this line if self.child_factory_class is None.

Signed-off-by: mulhern <amulhern@redhat.com>
Remove minimumSector method and _minimumSector attribute

minimumSector is unused and does not work properly as a property.

Signed-off-by: mulhern <amulhern@redhat.com>
Pass fname as first argument to shutil.copy2

It's hard for an analysis to detect that file is an unbound variable because
actually it is a built-in of the wrong type.

Signed-off-by: mulhern <amulhern@redhat.com>
Actually use argv parameter

This solution is more general than getting rid of the unused parameter.

Signed-off-by: mulhern <amulhern@redhat.com>
Make signature of _setSize match that of the method it overrrides.

It seems that if the name of the parameter matches pylint won't complain
about an unused argument.

Signed-off-by: mulhern <amulhern@redhat.com>
Removed unused argument 'options' from testMount

testMount() is only used in one place, and options is not passed there.

Signed-off-by: mulhern <amulhern@redhat.com>
Remove unused parameter in makeupdates.

Change invocation accordingly.

Signed-off-by: mulhern <amulhern@redhat.com>
Change name to avoid redefining built-in

The name is method-local.
Rename to avoid redefining parameter built-ins

When renaming a parameter it is necessary to check whether the parameter is
used as a keyword in function invocations. In all these cases, that does
not occur, i.e, in blivet, anaconda, open-lmi these functions, if they are
invoked, are only invoked using positional arguments.