Hlookup

the following changes should fix the hlookup operator. I tested it on the latest Drill code, on a single node (embedded) with hbase and it's working fine.
I am pretty sure that toString doesn't work.


On Sat, Nov 1, 2014 at 7:34 PM, adeneche <notifications@github.com> wrote:

> In
> hlookup/src/main/java/com/tdunning/drill/exec/expr/fn/impl/HbaseLookup.java:
>
> >          }
> >
> >          public void eval() {
> > -            // read the data, fill in the result using the writer
> > -            helper.lookup(table, columns, key, writer);
> > +            if (key.isSet == 0) {
> > +                return;
> > +            }
> > +
> > +            java.nio.charset.Charset utf8 = com.google.common.base.Charsets.UTF_8;
>
> Testing using:
> table.buffer.toString(utf8)
> but it doesn't seem to work, it returns an empty string. So I guess the
> current code is the only way to get the String from a VarCharHolder.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tdunning/incubator-drill/pull/1/files#r19709304>.
>