Fix PUP-1568 - no success variable anymore

In the refactoring within 000b8fef the success variables was
removed. So the error message shouldn't anymore use it.
Fix broken spec & wording of error message.

While working on 658f1237c1596a6f735b7b707130fc0897a1a113 I stumbled
accross another messages that would say 'with error code false', which
doesn't make a lot of sense. Also the plain 'expect raise_error' was
masking another problem with tests. One should always only look for the
exact expected error and not just general for any kind of error.
(PUP-1510) Fixed forcelocal bug with ensure => absent

The forcelocal option was referencing a command that was not
previously defined which was throwing an exception.  The forcelocal
feature does not need to use a special command to delete local users,
only to add them.  So the special logic for delete was removed and
forcelocal now uses userdel to ensure absent on a user.
(maint) Improve Puppet::Util::Docs.scrub's handling of one-liners

One-liner handling wasn't behaving as expected. Sometimes one-liners are
buffered with extra newlines before and/or after, and in these cases, scrub
wasn't catching the leading whitespace.

This commit makes it behave as intended, and adds a test showing the intended
behavior.
(maint) Make setting not screw up when interpolating a false value

This was a class nil/false screwup.
Merge pull request #2361 from nfagerlund/maint_scrub_improvement

(maint) Improve Puppet::Util::Docs.scrub's handling of one-liners
Merge pull request #2354 from jjulien/pup1510

(PUP-1510) Fixed forcelocal bug with ensure => absent
(PUP-542) Add structured facts to immutable $facts

When opting in with trusted_node_data or immutable_node_data the facts
are also available via $facts, an immutable hash of data.
(PUP-542) Improve descriptions of trusted & immutable node data settings
(maint) Add test for interpolation of setting having false value
Merge pull request #2324 from duritong/fix/master/PUP-1568_fix_error_reporting

Fix/master/pup 1568 fix error reporting
PUP-1772 Change api for Puppet::Util::Profiler#profile to public

This patch changes the YardDoc annotations so that the class
'Puppet::Util::Profiler' is now public, and its method #profile
is also public.

The remaining methods are still marked as private, as they
aren't really needed by most external consumers.

Signed-off-by: Ken Barber <ken@bob.sh>
(maint) Add Ruby 2.1.0 to Travis CI
Merge branch 'pr/2346'

* pr/2346:
  (maint) Add Ruby 2.1.0 to Travis CI

This closes GH-2346.
(PUP-542) Make tests pass on 1.8.7 ('hash' vs 'Hash' in message)
Merge pull request #2390 from kbarber/ticket/master/PUP-1772-profile-method-public-api

PUP-1772 Change api for Puppet::Util::Profiler#profile to public
Merge pull request #2389 from hlindberg/pup-542_structured-facts-support

(PUP-542) Add structured facts support
(PUP-1564) add :uninstall_options feature to package rpm provider
(PUP-1564) Add uninstall_options to RPM provider docs
Merge pull request #2319 from jhoblitt:feature/rpm_provider_uninstall_options

Merged with a fixup to spec tests to account for changes in abfc76c. Added an
update to generalize install options documentation from bb829da to cover
uninstall options as well.

(PUP-1564) Add uninstall_options to RPM provider docs
(PUP-1564) add :uninstall_options feature to package rpm provider