Might be. Good thinking.


On Tue, Jan 14, 2014 at 6:25 PM, Ryan Carlson <notifications@github.com>wrote:

> In src/main/java/org/cru/crs/api/PermissionResource.java:
>
> > +		Simply.logObject(permission, PermissionResource.class);
> > +		
> > +		if(IdComparer.idsAreNotNullAndDifferent(permissionId, permission.getId())) {
> > +			throw new BadRequestException();
> > +		}
> > +		
> > +		/*above, we've just checked for the case that both are non-null and different, this assures us
> > +		 * that the value in the path is set in the body in case the body is null*/
> > +		permission.setId(permissionId);
> > +		
> > +		updatePermissionProcess.updatePermission(permission, crsLoggedInUser);
> > +		
> > +		return Response.noContent().build();
> > +	}
> > +	
> > +	@DELETE
>
> Might be useful for audit purposes?
> … <#1439312ff9cd1fc8_>
> Sent from my iPhone
>  On Jan 14, 2014, at 6:03 PM, hlbraddock <notifications@github.com>
> wrote: In src/main/java/org/cru/crs/api/PermissionResource.java: > +
> Simply.logObject(permission, PermissionResource.class); > + > +
> if(IdComparer.idsAreNotNullAndDifferent(permissionId, permission.getId()))
> { > + throw new BadRequestException(); > + } > + > + /*above, we've just
> checked for the case that both are non-null and different, this assures us
> > + * that the value in the path is set in the body in case the body is
> null*/ > + permission.setId(permissionId); > + > +
> updatePermissionProcess.updatePermission(permission, crsLoggedInUser); > +
> > + return Response.noContent().build(); > + } > + > + @DELETE<https://github.com/DELETE>And why not actually delete the permission after all? — Reply to this email
> directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CruGlobal/conf-registration-api/pull/114/files#r8881096>
> .
>