You probably want `make` to still lint the TS mod.


On Sun, May 18, 2014 at 10:51 AM, Paul Chote <notifications@github.com>wrote:

> In OpenRA.Mods.RA/Widgets/Logic/InstallMusicLogic.cs:
>
> > +				{
> > +					Log.Write("debug", "Mounting the new MIX file and rebuild of scores list failed:\n{0}", e);
> > +				}
> > +			};
> > +
> > +			var cancelButton = installMusicContainer.GetOrNull<ButtonWidget>("CANCEL_BUTTON");
> > +			if (cancelButton != null)
> > +				cancelButton.OnClick = () => Ui.CloseWindow();
> > +
> > +			var ripFromDiscButton = installMusicContainer.GetOrNull<ButtonWidget>("RIP_
> FROM_CD_BUTTON");
> > +			if (ripFromDiscButton != null)
> > +			{
> > +				ripFromDiscButton.OnClick = () =>
> > +				{
> > +					previousShowShellSetting = Game.Settings.Game.ShowShellmap;
> > +					Game.Settings.Game.ShowShellmap = false;
>
> This will need to be more robust. The setting will remain disabled if you
> cancel the installation or quit the game before it completes.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/OpenRA/OpenRA/pull/5304/files#r12771193>
> .
>