Remove trailing comma which breaks 2.6 compat
Merge pull request #239 from GregSutcliffe/master

Remove trailing comma which breaks 2.6 compat
Pulling in pgconf module from camptocamp/puppet-pgconf

This includes the following changes:
  - Hooking up pgconf module to postgresql to manage postgresql.conf
   - pgconf includes a type and provider for postgresql.conf the provider
     is a simple parsed file following basic ini parsing.
  - Add config_entry.pp which wraps the pgconf module.
  - Replace file_line resources by postgresql::config_entry in beforeservice.pp
  - Adding unit tests for the newly introduced functionality
Adding anchors around contained resources
Major rewrite to solve order dependencies and unclear public API

This is a very very large change to the module. It started out as a fix to add
postgresl::server::config_entry, and quickly became a rewrite to fix a lot of
ordering issues inherent in the API.

Since this changes the Public API it is considered a backwards compatible
change.

See the upgrading guide in README.md for more details as to what has been
modified in this patch.

Signed-off-by: Ken Barber <ken@bob.sh>
Add datadir back, as its used within a lot of tests

Signed-off-by: Ken Barber <ken@bob.sh>
Fix debian 7 regexp, rename to default_version and some cleanup

Signed-off-by: Ken Barber <ken@bob.sh>
Include firewall class in firewall based test

Signed-off-by: Ken Barber <ken@bob.sh>
Provide package removal fixes for Debian tests

This patch provides fixes to help tests pass on Debian. The failures were in
relation to the lack of proper removal of the server and contrib parts. Setting
the ensure => purged parameter for removal seems to have solved a lot of this.

Also, the ordering for contrib being (un)installed needed some work.

I've also made sure we use 'purged' a lot more in tests to make sure we clean
up after ourselves properly.

Signed-off-by: Ken Barber <ken@bob.sh>
Modify tests for postgresql::server to test for purged state

Since we are now forcing ensure => purged in places, some unit tests need to
be reworked to accept that.

Signed-off-by: Ken Barber <ken@bob.sh>
Fix repo removal for testing purposes

Signed-off-by: Ken Barber <ken@bob.sh>
Calculate default version for Fedora

Signed-off-by: Ken Barber <ken@bob.sh>
Skip firewall tests for Fedora

Signed-off-by: Ken Barber <ken@bob.sh>
Fix selinux permissions for fedora tests

Signed-off-by: Ken Barber <ken@bob.sh>
Correct some more failing tests

Signed-off-by: Ken Barber <ken@bob.sh>
Add switch for service_name that works for centos

Signed-off-by: Ken Barber <ken@bob.sh>
Various cleanups

Signed-off-by: Ken Barber <ken@bob.sh>
Fix table_grant tests

Signed-off-by: Ken Barber <ken@bob.sh>
Make sure $ensure is passed through to repo correctly

Signed-off-by: Ken Barber <ken@bob.sh>
serverspec + some cleanup

Signed-off-by: Ken Barber <ken@bob.sh>