Can you just make the default value be 10 for the new argument? It's really
just that. There doesn't have to be a constant for that value.


On Tue, Jan 21, 2014 at 3:38 PM, DamirSvrtan <notifications@github.com>wrote:

> In lib/stormpath-sdk/http/http_client_request_executor.rb:
>
> > @@ -64,39 +52,23 @@ def execute_request(request)
> >            return @redirect_response
> >          end
> >
> > -        if @redirect_response
> > -          @redirects_limit = REDIRECTS_LIMIT
> > -          @redirect_response
> > -        else
> > -          Response.new response.http_header.status_code,
> > +        @redirects_limit = REDIRECTS_LIMIT
>
> Okay, i can transfer it to being an argument, but I will either have to
> transfer the REDIRECTS_LIMIT constant to another class (data_store, not
> really seeing it having anything to do with data_store) or the first call
> should have the redirects_limit parameter equal to nil and then if nil, set
> the variable to the REDIRECTS_LIMIT value and decrease it on every other
> call.
>
> I will change it when i make changes to the Rails SDK so i can test this
> out properly.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/stormpath/stormpath-sdk-ruby/pull/53/files#r9059778>
> .
>