Initial rubocop support.

Per the mailing list thread, introducing Rubocop as a replacement for Tailor.
Assuming Jenkins likes this, more pedantic patches will follow to make Rubocop
happy.

rubocop              | 24 files inspected, 1617 offences detected

Change-Id: I10077146fbaa015c4b74cac826761de273c5639d
Rubocop testing of the attributes and testing documentation.

The Testing section of the README.md was broken out into the new TESTING.md to
explain how the cookbook is being tested. Rubocop is testing the attributes/
files and the .rubocop.yml has documented excluded rules.

Change-Id: I0a5f4124a061617779425490d198c00d931c4cc1
Rubocop support for metadata.rb and Gemfile

Replace double-quotes with single-quotes for now, expect this to act as a gate
in the future.

Change-Id: I10ff8b23517cb334905b162ce14059dbf23d7bc8
Merge "Initial rubocop support."
Merge "Rubocop testing of the attributes and testing documentation."
Merge "Rubocop support for metadata.rb and Gemfile"
Add DB2 support to cinder on redhat platform

Add a new attribute
default["openstack"]["block-storage"]["platform"]["db2_python_packages"]

Change-Id: Ibfaef276788322867a9461235eeac8d5c706c3f5
Implements: blueprint db2-support
Initial rubocop support for recipes.

Per the mailing list thread, introducing Rubocop as a replacement for Tailor.
Assuming Jenkins likes this, more pedantic patches will follow to make Rubocop
happy. So far this is just spacing issues and adding UTF-8 headers, but more
work will need to be done to remove all of the changes for the .rubocop-todo.yml

Change-Id: I590ac5ec03ce6a00dd73027d6798e36105a32af1
Update spec_helper to include 'chefspec/berkshelf'

This minor change allows you to run rspec outside of strainer while
still having cookbook dependencies automatically handled by berkshelf
(which also means you can run individual chefspec tests).

Note that this change does marginally increase the time it takes to run
a strainer test.

A similar change was recently accepted in the openstack-compute
cookbook.

Change-Id: I4d8256215dd4ca4d628db79e69ae9bf24e994277
Initial rubocop support for ChefSpec tests.

Per the mailing list thread, introducing Rubocop as a replacement for Tailor.
Assuming Jenkins likes this, more pedantic patches will follow to make Rubocop
happy. So far this is just spacing issues and adding UTF-8 headers, but more
work will need to be done to remove all of the changes for the .rubocop-todo.yml

Addresses: blueprint rubocop-for-block-storage
Change-Id: Ibb11739e452016c101995a371d031faeeb7e7683
Merge "Update spec_helper to include 'chefspec/berkshelf'"
Merge "Initial rubocop support for ChefSpec tests."
Merge "Add DB2 support to cinder on redhat platform"
Add Storwize/SVC configuration attributes

Change-Id: Ica5513abdc8bed298edb475f0c44e2eabf50b93b
explicitly set rpc_backend in cinder.conf

Implements: blueprint centos-rhel-for-block
Fixes: bug #1269432

The following is a default value in cinder:

rpc_backend=cinder.openstack.common.rpc.impl_kombu

Using RDO (rhel/centos) packages, this gets overridden in
/usr/share/nova/cinder-dist.conf to 'impl_qpid'.

In order to cleanly set this back to the default value (which is what we
want as a default in the cookbooks), we need to explicitly set this in
cinder.conf

Change-Id: I5bd0c6ed95a6d02202b19708f15a58ec43a2fe6c
Move to use "get_password" instead of "{user,service,db}_password"

The user_password, service_password and db_password functions are redundant
since they simply call "secret". Creates a get_password function that will
accept a "type" of db, service or user.

All instances of these calls have been changed to call get_password

Change-Id: Ifdb5c7b3f590431aaa7ffc021cdee34899ac8c15
Partial-Bug: #1195915
Merge "Add Storwize/SVC configuration attributes"
change default cinder.volume.driver

Fixes: bug #1269438

New lvm iscsi driver path is:

cinder.volume.drivers.lvm.LVMISCSIDriver

Change-Id: I3427e80c78ec52a6b02cd42d25f425e03e15f01f
Need create init.d script file before enable the service

Closes-bug: #1267095

Change-Id: I7897c6cb03ae3040a819dc86f45fc6c7dea9a3e5
Add name template attributes

Change-Id: I861451d137c2436ae8bb792570751d1ddb754906