question spec done
controller implementation done