Add the remaining unittests to the ClientWrapper class

This patch also pep8-fy the imports in the test_client_wrapper.py.

Closes-Bug: #1316549
Change-Id: Iaf154886c5c05f94ac045fbc99f93915bb91c878
Nova Ironic driver get_info() to return memory stats in KBytes

According to the base class 'max_mem' and 'mem' should be returned in
KBytes, other drivers are also converting those values to KBytes so
Ironic should as well.

This patch also add the missing docstring for the get_info() method.

Change-Id: Ia7063b994d506b511271920678868d336a776ec9
Update Nova Ironic Driver destroy() method

* Add DocString

* Add a missing parameter 'destroy_disks', although not used by Ironic
  we should keep the function signature consistent with the base class.

* When calling destroy() passing an non-existent instance log a warning
  message instead of debug. As suggested on the base class:

  "If the instance is not found (for example if networking failed), this
  function should still succeed. It's probably a good idea to log a
  warning in that case."

Change-Id: I0e7d9a9e5522606bafd5ef6d9dbe525ad39026d2
Add/Update docstrings in the Nova Ironic Driver

Add and update the docstrings in the Nova Ironic Driver. The 'node'
parameter from the power_on and power_off method was removed because
it's not part of the interface and wasn't being used.

To maintain the function signature consistent with the base class the
'node' parameter from the get_available_resource() method was renamed to
'nodename'.

Also, the method manage_image_cache() was removed from the driver because
it was simply calling "pass", just like the base class.

Change-Id: I0d2fe07992bde7bf09df934282b0551a35e99c1c
Fix the section name in CONTRIBUTING.rst

The name of the section 'If you're developer, start here'
has changed in the wiki. This commit updates it to correctly
refer to the good section.

Changed urls to use https

Change-Id: I7cec7b6ec209ae9ad95035dac4c9da4e09d6e0dc
Closes-bug: #1335189
Update Nova's available resources at termination

This updates ClusteredComputeManager to override terminate_instance() with
a call to update_available_resource().  The goal here is to limit the lag
between when an Ironic node has been freed and when it will become available
again to the Nova.  This avoids scheduling errors against Ironic node
inventories with high utilization and/or limited node resources.

Change-Id: I767cb97d9b182f1f9528d078b07a85ffbad313ba
Closes-bug: #1334027
Fix glance endpoint tests

Glance endpoints are now located under http_client after reworking
for glance blueprint common-client-library-2. Change located in
glanceclient commit I5addc38eb2e2dd0be91b566fda7c0d81787ffa75

Test support both glanceclient versions for backward compatibility.

Change-Id: Idba3a05bdb09674b44dcc21c9427b4b85a29a1f7
PEP fixes for the Nova driver

Several PEP violations were found when copying the Nova driver
to Nova's tree. This patch applies those fixes within Ironic's tree.

Change-Id: Ib6f082759b4398dd59829e71977bf3187baf4f6f
pep8 cleanup of Nova code

For various reasons, the Nova code in the Ironic tree is not covered by
the pep8 check.  This is a manual pass and cleanup of the scheduler
and driver code until this merges into Nova and can be gated on pep8
coverage again.

Change-Id: I1ab114c4bd152992262b1de8e763b407e92ca69f
Merge "PEP fixes for the Nova driver"
Merge "pep8 cleanup of Nova code"
Merge "Fix the section name in CONTRIBUTING.rst"
Updated from global requirements

Change-Id: I7a3158247a284ea90be769920b2f4f389f98c089
Update nova rebuild to account for new image

Update the Nova driver's rebuild() to account for changes in the instance image
during rebuild.  Currently, rebuild ignores user requests to rebuild with a
new image, making it impossible to do image-based upgrades.  This adds logic
to the patcher to account for the preserve_ephemeral flag and updates rebuild()
to use the patcher to re-patch all driver_info during rebuild.

This also adds missing test coverage of the rebuild code.

Change-Id: I6c8aacd36e0095d0590a1dc552730f2d52036225
Closes-bug: #1334905.
Merge "Add the remaining unittests to the ClientWrapper class"
Merge "Nova Ironic driver get_info() to return memory stats in KBytes"
Merge "Update Nova Ironic Driver destroy() method"
Merge "Add/Update docstrings in the Nova Ironic Driver"
Minor cleanups to nova virt driver and tests

- remove unused classmethod "instance" from nova.virt.ironic driver
- two more pep8 fixes in unit tests

Change-Id: I0ba4b4717abe8bb8fdb9092c8e07332c3c011a22
Merge "Update Nova's available resources at termination"