Set is_public to False by default for volume backed snapshots

This update results in the same behavior that is already implemented
in _create_image where the meta_data for is_public is set to False.

Change-Id: Ie0720d5c847871527db7d9477ca6cb05abe7a1a5
Closes-Bug: #1255316
Pass rbd_user id and conf path  as part of RBD URI for qemu-img

Unlike rados.py, qemu-img does not use id from CEPH_ARGS and has to be
given a ceph user id and conf path explicitly in RBD URI

Closes-Bug: #1261675
Change-Id: I9226515f2a860ed45d12012fd5b6bc7e842f6d32
VMware: unnecessary session reconnection

An error FAULT_NOT_AUTHENTICATED could imply that there is a problem
with the backend or that no values were found (for example there are
no running VMS). In the latter case the connection should not
be restarted.

The patch also ensures that the session is restarted if there are
connection issues.

This issue occasionally causes CI issues with minesweeper.

Closes-bug: #1265512

Co-authored-by: Shawn Harsock <hartsocks@vmware.com>

Change-Id: Ibfa83d0b5b93680890aad8c88c041fa344765448
Refactor CIDR field to use netaddr.IPNetwork

This makes the CIDR field become the IPNetwork field (and associate
versioned fields). It also uses the netaddr.IPNetwork class, which
is what should have been done in the first place.

Wire format is unchanged, so we can make this without any version
bumps or upgrade impact.

Related to blueprint nova-network-objects

Change-Id: I1a3ab6a5f4c624f3da0ab1c78c75c6f1e474541f
Consolidate the blockdev related filters

Seeing a "/usr/local/bin/nova-rootwrap: Unauthorized command" error
in the logs when  "blockdev --flushbufs" is executed because of the
existing blockdev in compute.filters. We need to merge both into a
single RegExpFilter

Change-Id: Ic323ff00e5c23786a6e376e67a4ad08f92708aef
Fix updating device names when defaulting

If the virt driver does not support defaulting device names, the default
behaviour of defaulting them in the manager was calling the conductor
block_device_mapping_update method with the wrong arguments, which
caused a TypeError and ultimately a failure to boot the instance.

This patch fixed the signature and adds a test that exercises it so
that it does not regress.

Closes-bug: #1260806
Change-Id: I6116540c9aca4847afacf80b3d1e0c027c364159
xenapi: stop server destroy on live_migrate errors

Currently where there are errors after live-migration has completed, the
server is destroyed, which for XenAPI driver, means the server no longer
exists, because XenServer has already deleted the source VM.

Closes-Bug: #1262206
Change-Id: I7f827f5d972da26f5d1edae7a22fb45a1f5dd6ca
Merge "Fix updating device names when defaulting"
Merge "Refactor CIDR field to use netaddr.IPNetwork"
Merge "VMware: unnecessary session reconnection"
Merge "xenapi: stop server destroy on live_migrate errors"
Merge "Pass rbd_user id and conf path  as part of RBD URI for qemu-img"
Merge "Set is_public to False by default for volume backed snapshots"
Merge "Consolidate the blockdev related filters"