thinking through how to handle params