Remove extra space at the end of help string

Extra spaces in help strings break the niceness gate test for
openstack-manuals (see https://review.openstack.org/#/c/77625/1).

This patch removes an extra space to ease the automatic import of config options
in the docs repository.

Change-Id: I005d0a0a260e11adf8c7bb74df3933f4f8f615d9
Error out failed migrations

This change causes migrations to have their status set to error when
either the resize_instance or finish_resize methods raise an exception.
This prevents continuous logging of stalled migrations.

Change-Id: Ie752e4833d28fd679c6d1abbc9da5f0ef57f5ec4
Closes-bug: 1258275
VMware: VimException __str__ attempts to concatenate string to list

Forces the correct parameter use in VimException and VimFaultException
both exceptions have similar signatures but very different uses. This
change forces a developer to deal with misuse of the exceptions
early in their development cycle (provided the do due dilligence with
their testing.)

Closes-bug: 1287884

Change-Id: I34753382677e3315ea4a71cfe9b3b82e9f9159bb
enable cloning for rbd-backed ephemeral disks

Currently when using rbd as an image backend, nova downloads the
glance image to local disk and then copies it again into rbd. This
can be very slow for large images, and wastes bandwidth as well as
disk space.

When the glance image is stored in the same ceph cluster, the data is
being pulled out and pushed back in unnecessarily. Instead, create a
copy-on-write clone of the image. This is fast, and does not depend
on the size of the image. Instead of taking minutes, booting takes
seconds, and is not limited by the disk copy.

Add some rbd utility functions from cinder to support cloning and
let the rbd imagebackend rely on librbd instead of the rbd
command line tool for checking image existence.

Add an ImageHandler for rbd that does the cloning if an applicable
image location is available. If no such location is available, or rbd
is not configured for ephemeral disks, this handler does nothing, so
enable it by default.

blueprint rbd-clone-image-handler
Closes-bug: 1226351
Change-Id: I9b77a50206d0eda709df8356faaeeba35d232f22
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
Add declaration of 'refresh_instance_security_rules' to virt driver

The method 'refresh_instance_security_rules' was not defined
in the virt driver ComputeDriver class. In cases where the
underlying virt driver does not support security groups
an exception would be encountered indication that the driver
class does not have the specific attribute.

In addition to adding the method the patch set also catches the
exception NotImplementedError and logs a warning.

Change-Id: Ia36b0dfb54a3ede86467d87f0650a0902adb6d46
Closes-bug: #1269448
Merge "Error out failed migrations"
Merge "VMware: VimException __str__ attempts to concatenate string to list"
Merge "Add declaration of 'refresh_instance_security_rules' to virt driver"
Merge "Remove extra space at the end of help string"
Merge "enable cloning for rbd-backed ephemeral disks"