Let's land it and get improvements in later. My bad.

Sent from my iPhone

On Mar 14, 2014, at 11:46 PM, "Bill Fisher" <notifications@github.com<mailto:notifications@github.com>> wrote:


In examples/todomvc-flux/js/stores/TodoStore.js:

> + * TodoStore
> + */
> +
> +var AppDispatcher = require('../dispatcher/AppDispatcher');
> +var EventEmitter = require('events').EventEmitter;
> +var merge = require('react/lib/merge');
> +
> +var _todos = {};
> +var _areAllComplete = false;
> +
> +/**
> + * Create a TODO item.
> + * @param  {string} text The content of the TODO
> + */
> +function create(text) {
> +  // Hand waving here -- not showing how this interacts with XHR or persistent


I can add simple localStorage for sure, but that only tells a fraction of the tale. How far down that road do you want to go? Optimistic rendering? Error states? I left all this out to keep it simple, but yes I can certainly add some code to maintain localStorage data.

—
Reply to this email directly or view it on GitHub<https://urldefense.proofpoint.com/v1/url?u=https://github.com/facebook/react/pull/1258/files%23r10633780&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=qYx6qLphxKhA5vHBqr9vuw%3D%3D%0A&m=BRHagu3bvL4bbWUINRG8GNDXQ3hgM%2B73yLAPYAwsfCw%3D%0A&s=a776804ecdefb82bc87a4f6246b37501ce5f45d7530f31f2858b0ce5dcf13e4e>.