(private message)

Hey Mikael,

Is the makefile ok for you (I'm not an expert in this area)? I'm currently
talking with Darran on the last things that need to be done to  the oled
library before merging his request. This actually lead to a bigger
discussion on when to accept pull requests ^^

Mathieu


On Mon, Feb 17, 2014 at 10:49 PM, Mikael Albertsson <
notifications@github.com> wrote:

> In source_code/Makefile:
>
> > +
> > +BASEDIR := $(PWD)
> > +
> > +LIBS := -lm -lmooltipass
> > +
> > +# library sources for the mooltipass library
> > +LIBRARIES := CARD FLASH USB OLED UTILS GRAPHICS
> > +#LIBRARIES := oledmp spi CARD FLASH USB
> > +
> > +# Search paths for the mooltipass libraries
> > +LIBRARYPATHS := $(BASEDIR)/src $(BASEDIR)/src/lib
> > +
> > +# get full path for each library
> > +LIBDIRS := $(foreach path, $(LIBRARYPATHS), \
> > +    		   $(foreach lib, $(LIBRARIES),  \
> > +		   $(wildcard $(path)/$(lib)/.)))
>
> Very good. There's nothing wrong with the functionality here, by the way.
> My other suggestions were just meant to try to keep the Makefile
> readability to a maximum, as Makefiles in general tend to move towards a
> state of "this works, we no longer understand why" very quickly. If I feel
> that I can simplify it without sacrificing functionality, I can always post
> a pull request later. I didn't mean to keep your changes hostage just for
> some nit-picking =)
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/limpkin/mooltipass/pull/11/files#r9805457>
> .
>