knocikng commit